This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch release/2.24/master updated. glibc-2.24-52-g0505a57
- From: fw at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 9 Jun 2017 11:09:20 -0000
- Subject: GNU C Library master sources branch release/2.24/master updated. glibc-2.24-52-g0505a57
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, release/2.24/master has been updated
via 0505a57d4381f2baaeed73e96b161d0fb313fa5c (commit)
from 7b60553e360731338631ccdda71590ac5deca137 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=0505a57d4381f2baaeed73e96b161d0fb313fa5c
commit 0505a57d4381f2baaeed73e96b161d0fb313fa5c
Author: Florian Weimer <fweimer@redhat.com>
Date: Fri May 12 11:58:09 2017 +0200
fork: Remove bogus parent PID assertions [BZ #21386]
(cherry picked from commit 1d2bc2eae969543b89850e35e532f3144122d80a)
diff --git a/ChangeLog b/ChangeLog
index 33d05e4..3d4f5f8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2017-05-12 Florian Weimer <fweimer@redhat.com>
+
+ [BZ #21386]
+ * sysdeps/nptl/fork.c (__libc_fork): Remove assertions on the
+ parent PID. The assertion in the child is incorrect with PID
+ namespaces.
+
2017-06-07 Arjun Shankar <arjun.is@lostca.se>
* sysdeps/unix/sysv/linux/tst-clone2.c: Do not
diff --git a/NEWS b/NEWS
index 71b41ea..82a718f 100644
--- a/NEWS
+++ b/NEWS
@@ -24,6 +24,7 @@ Security related changes:
The following bugs are resolved with this release:
[21289] Fix symbol redirect for fts_set
+ [21386] Assertion in fork for distinct parent PID is incorrect
Version 2.24
diff --git a/sysdeps/nptl/fork.c b/sysdeps/nptl/fork.c
index 02ff793..a5d1e86 100644
--- a/sysdeps/nptl/fork.c
+++ b/sysdeps/nptl/fork.c
@@ -131,10 +131,6 @@ __libc_fork (void)
__malloc_fork_lock_parent ();
}
-#ifndef NDEBUG
- pid_t ppid = THREAD_GETMEM (THREAD_SELF, tid);
-#endif
-
#ifdef ARCH_FORK
pid = ARCH_FORK ();
#else
@@ -147,8 +143,6 @@ __libc_fork (void)
{
struct pthread *self = THREAD_SELF;
- assert (THREAD_GETMEM (self, tid) != ppid);
-
/* See __pthread_once. */
if (__fork_generation_pointer != NULL)
*__fork_generation_pointer += __PTHREAD_ONCE_FORK_GEN_INCR;
@@ -222,8 +216,6 @@ __libc_fork (void)
}
else
{
- assert (THREAD_GETMEM (THREAD_SELF, tid) == ppid);
-
/* Release acquired locks in the multi-threaded case. */
if (multiple_threads)
{
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 7 +++++++
NEWS | 1 +
sysdeps/nptl/fork.c | 8 --------
3 files changed, 8 insertions(+), 8 deletions(-)
hooks/post-receive
--
GNU C Library master sources