This is the mail archive of the gsl-discuss@sources.redhat.com mailing list for the GSL project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bug in Levenbeg-Marquardt Algorithm


Hans Ekkehard Plesser writes:
 > I now had a look at the original MINPACK code (lmder.f).  They set
 > par_lower to 0 for rank deficient r, so here is a patch that does the
 > same in lmder.c . 

Thanks!  That looks sensible.  Do you have a test case with a
rank-deficient matrix that could be added to the test suite?

Brian

 > 
 > 
 > 
 > 270c270,277
 > <     par_lower = fp / (delta * phider);
 > ---
 > > 
 > >     /* w == zero if r rank-deficient, 
 > >        then set lower bound to zero form MINPACK, lmder.f 
 > >        Hans E. Plesser 2002-02-25 (hans.plesser@itf.nlh.no) */
 > >     if ( wnorm > 0 )
 > >       par_lower = fp / (delta * phider);
 > >     else
 > >       par_lower = 0.0;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]