This is the mail archive of the gsl-discuss@sources.redhat.com mailing list for the GSL project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gsl_siman bug -- wrong path


Sorry list-ers,

	I included the wrong directory in the message below. The path that
the bug is in is gsl-1.1.1/siman/siman.c on line #99.

pete 


On Thu, 11 Jul 2002, Peter S. Christopher wrote:

> Hi there,
> 
> 	I think I've found a bug in the gsl_siman_solve routine. I'm using
> gsl 1.1.1. The bug resides in the file gsl-1.1.1/siman.c on line #99. It
> currently reads
> 
> 	} else if (exp (-(E - new_E)/(params.k * T))
>                  * gsl_rng_uniform(r) < 0.5) {
> 
> I believe it should read something more like
> 
> 	} else if (exp ((E - new_E)/(params.k * T)) > 
>                    gsl_rng_uniform(r)) {
> 
> The first version isn't consistent with the documentation. Further, and I
> think that this is important, it doesn't allow users to set the
> temperature such that he/she starts out with near 100% acceptance. Let me
> know if there's any other info I can provide.
> 
> Thanks for the good work,
> Pete Christopher
> 
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]