This is the mail archive of the
gsl-discuss@sources.redhat.com
mailing list for the GSL project.
Re: gsl_isnan in eigen/*.c for 1.3
On Wed, Jan 01, 2003 at 09:30:28PM +0000, Brian Gough wrote:
> Albert Chin writes:
> > Why do eigen/symm.c, eigen/symmv.c, eigen/herm.c, and eigen/hermv.c
> > use gsl_isnan() rather than isnan()? gsl_isnan is defined only when
> > using Microsoft Visual C++ (sys/infnan.c) or if HAVE_IEEE_COMPARISONS
> > is defined. On HP-UX 10.20, HAVE_IEEE_COMPARISONS is not defined. As
> > isnan is defined to gsl_isnan in config.h, why not use isnan()?
> >
> > Is it really bad for HP-UX 10.20 to fail the HAVE_IEEE_COMPARISONS
> > test?
> >
> > Ditto for sys/test.c.
>
> It was a bug. The library should use isnan, etc internally, and have
> them replaced by gsl_isnan through config.h. If isnan is available
> and IEEE comparisons aren't then gsl_isnan should be defined in terms
> of isnan. Try this patch (untested).
The patch works. Thanks!
--
albert chin (china@thewrittenword.com)