This is the mail archive of the guile@sourceware.cygnus.com mailing list for the Guile project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

docstrings in Guile!


>>>>> "Greg" == Greg J Badros <gjb@cs.washington.edu> writes:

Greg> I'm sure there will be build problems, etc.  Please report them
Greg> here, but *first* tell me how great this is! :-) I've literally
Greg> spent 20 hours in the last two days trying to make Guile ready
Greg> for the 21st century! :-)

Very nice!  Should make adding documentation easy enough for even me
to do!

Nevertheless, a teeny problem in make-shared-substring that
broke match:suffix, the default value for the end of the substring
wasn't being set correctly, patch below:

Index: libguile/strings.c
===================================================================
RCS file: /cvs/guile/guile/guile-core/libguile/strings.c,v
retrieving revision 1.16
diff -u -r1.16 strings.c
--- strings.c   1999/12/13 03:40:23     1.16
+++ strings.c   1999/12/14 01:15:10
@@ -369,7 +369,7 @@
 
   SCM_VALIDATE_ROSTRING(1,str);
   SCM_VALIDATE_INT_DEF_COPY(2,frm,0,f);
-  SCM_VALIDATE_INT_DEF_COPY(3,to,0,t);
+  SCM_VALIDATE_INT_DEF_COPY(3,to,SCM_ROLENGTH(str),t);
 
   SCM_ASSERT_RANGE (2,frm,(f >= 0));
   SCM_ASSERT_RANGE (3,to, (f <= t) && (t <= SCM_ROLENGTH (str)));

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]