SCM_NIMP folded into macro defs [was Re: guile/guile-core/libguile async.h coop-defs.h ...]

["Greg J. Badros" <gjb at cs dot washington dot edu>]

Mikael Djurfeldt <mdj@mdj.nada.kth.se> writes:

> "Greg J. Badros" <gjb@cs.washington.edu> writes:
> 
> > It was preceded by some discussion -- see the thread started at:
> > 
> > http://sourceware.cygnus.com/ml/guile/1999-12/msg00229.html
> 
> It is indeed precarious first to quit reading the guile list, and,
> then, complaining that there hasn't been discussions...  Why is
> life so complicated?  :(
> 
> > The "massively" is only until I remove all the spurious SCM_NIMP() from
> > the guile source.  Once that is done, it'll be a rare case where the
> > code expands any differently than before.
> 
> I'm thinking about the cases where the NIMP test is unnecessary to do.
> I hope, at least, that someone will go through the evaluator and put
> in sloppy versions of the tests there.

My guess is that there'll be at most a negligible performance hit.  It
makes more sense to just profile en masse and find the places where
there is a big win to changing code.

> > And I reiterate that I got *no* negative feedback
> 
> Well, at any rate you won't get more negative feedback from me, 'cause
> I'm temporarily out of half hours.  (But that doesn't mean that I have
> yet completely understood that the macro change is good.)

It's not a win yet, really;  the win comes when I simplify the code for
not having to do the SCM_NIMP inline at macro invocation sites because
it's been folded into the macro definition.

> In any case, I don't feel particularly worried overall for letting
> you guys take care of Guile from now on.

Thanks for the kinda-sorta vote of confidence. :-)

Greg