This is the mail archive of the
guile@sourceware.cygnus.com
mailing list for the Guile project.
Re: more cvs guile stuff :)
- To: "Dale P. Smith" <dpsm at en dot com>
- Subject: Re: more cvs guile stuff :)
- From: "Greg J. Badros" <gjb at cs dot washington dot edu>
- Date: 08 Mar 2000 14:15:06 -0800
- Cc: guile at sourceware dot cygnus dot com, Eric Moore <moore at chem dot cmu dot edu>
- References: <14533.51998.846639.288287@lovecraft.chem.cmu.edu> <14533.52913.533731.679858@lovecraft.chem.cmu.edu> <14534.3622.765907.135365@lovecraft.chem.cmu.edu> <00Mar8.162143est.17026@gateway.elms.k12.oh.us>
"Dale P. Smith" <dpsm@en.com> writes:
> Eric Moore wrote:
> >
> > The recent changes in numbers.c to have logand and logior use
> > SCM_VALIDATE_ULONG_COPY break scwm.
> >
> > Actually, they break anything that uses (logand (lognot 2)) since
> > lognot uses scm_difference to return a negative number....
> >
> > So here's a patch, and also changes the ints SCM_VALIDATE_LONG_COPY
> > copies into into longs.
> >
> > (I'm not sure that the semantics are quite right with lognot and
> > logand and friends, but at least scwm doesn't throw errors constantly,
> > so has to be closer to correct :)
>
> Has anyone looked at the patches I sent in that update numbers.c with the
> latest logxxx routines from scm?
To where did you send them? I'm seeing a message from you about that
code, but no patch... I applied Eric's patch, which may have duplicated
and/or broken yours. (And yours may have had stuff done differently or
fixed more problems than his, so I definitely don't want it to get lost).
Please re-send, and if you can, comment on Eric's changes (now already
in CVS) relative to yours.
And I apologize if I missed your earlier patch.
Thanks,
Greg