This is the mail archive of the guile@sourceware.cygnus.com mailing list for the Guile project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

suspicious comparison of SCM value agains zero


Hi!

In unif.c, about line 2214, there is the following code:
  ok = ok && scm_array_set_x (SCM_ARRAY_V (ra), SCM_CAR (lst), SCM_MAKINUM (base));

This line is useless, since scm_array_set_x will either succeed and return
SCM_UNSPECIFIED, which is != zero, or in case of failure, scm_array_set_x
will throw an error.

If nobody objects, I will just remove that line.

Best regards
Dirk Herrmann


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]