This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: [PATCH] Add type parameter to set_raw_breakpoint()
- To: insight at sources dot redhat dot com
- Subject: Re: [PATCH] Add type parameter to set_raw_breakpoint()
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Sat, 12 May 2001 01:55:12 -0400
- Cc: Kevin Buettner <kevinb at cygnus dot com>
- References: <1010511200742.ZM28831@ocotillo.lan>
> I've just committing the following changes. For more information on the
> corresponding changes to breakpoint.c, see:
>
> http://sources.redhat.com/ml/gdb-patches/2001-05/msg00204.html
>
> Please note that set_raw_breakpoint() ought to either be declared
> extern in breakpoint.h or calls to this function should be removed from
> gdbtk-bp.c so that it can be made static in breakpoint.c.
It should be static. Insight should instead call the published interface:
/* Create a breakpoint at ADDRESS (a GDB source and line). */
enum gdb_rc gdb_breakpoint (char *address, char *condition,
int hardwareflag, int tempflag,
int thread, int ignore_count);
Andrew