This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

PATCH: Remove unused ITCL_DIR variable in libgui config.


Hi all.

While looking at libgui, I noticed what seems to be an unused
variable. The ITCL_DIR variable set in libgui configure.in is
not used anywhere in libgui. I can't help but think this is
just some old cruft that never got removed. There was a
comment about ITCL_SH in the configure.in file, but
that does not seem to matter since ITCL_SH is defined
with a fully qualified path in itclConfig.sh.

% grep ITCL_SH itclConfig.sh 
ITCL_SH='/tmp/build_insight/itcl/itcl/unix/itclsh'

This came up because as part of the Tcl/Tk upgrade, we are
moving to Itcl 3.2 which no longer builds in a unix or win
subdir. I am currently trying to remove any code that
uses the old build structure so that the transition
is as painless as possible.

Here is the ChangeLog entry that implements the change
along with the patch for configure.in:

2001-08-06  Mo DeJong  <mdejong@redhat.com>

        * Makefile.in: Regen.
        * configure: Regen.
        * configure.in: Remove unused ITCL_DIR variable.
        * library/Makefile.in: Regen.
        * src/Makefile.in: Regen.

Index: configure.in
===================================================================
RCS file: /cvs/src/src/libgui/configure.in,v
retrieving revision 1.5
diff -u -r1.5 configure.in
--- configure.in        2001/08/04 00:02:59     1.5
+++ configure.in        2001/08/06 20:49:50
@@ -100,10 +100,8 @@
 CYG_AC_PATH_ITCLCONFIG
 CYG_AC_LOAD_ITCLCONFIG
 
-dnl what is the path to itclsh?
 case ${host} in
 *cygwin*)
-       ITCL_DIR=itcl/itcl/win
         touch ac$$.c
         if ${CC} -c -mwin32 ac$$.c >/dev/null 2>&1; then
             case "$LIBGUI_CFLAGS" in
@@ -113,7 +111,8 @@
         fi
         rm -f ac$$.o ac$$.c
        ;;
-*)             ITCL_DIR=itcl/itcl/unix ;;
+*)
+       ;;
 esac
 
 AC_SUBST(LIBGUI_CFLAGS) 
@@ -126,7 +125,6 @@
 AC_SUBST(TK_BUILD_LIB_SPEC)
 AC_SUBST(TCL_BUILD_LIB_SPEC)
 AC_SUBST(TK_LIBS)
-AC_SUBST(ITCL_DIR)
 
 AM_CONDITIONAL(TCL_SHARED, test x$TCL_SHARED_BUILD = x1)
 

P.S.

Does anyone know what version of automake should be used to
regen for code on sources.redhat.com? Should the maintainer-tools
module be used? Some of the current configure scripts seem to
have been generated by autoconf 2.13 which is why I ask.

cheers
Mo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]