This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: Patch: restoring multi-line breakpoint commands
- To: Keith Seitz <keiths at cygnus dot com>
- Subject: Re: Patch: restoring multi-line breakpoint commands
- From: Tom Tromey <tromey at redhat dot com>
- Date: 04 Oct 2001 20:41:12 -0600
- Cc: Insight List <insight at sourceware dot cygnus dot com>
- References: <Pine.GSO.4.33.0110031315440.11248-100000@makita.cygnus.com>
- Reply-To: tromey at redhat dot com
>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:
Keith> Can you give this patch a look over and tell me if you see
Keith> anything glaringly wrong?
The C part of the patch looks fine to me.
Keith> + sprintf_append_element_to_obj (obj, "loop_break");
Using sprintf_append_element_to_obj is sort of overkill, but I don't
imagine it matters.
Keith> + # escape "$", "[", and "]"
Keith> + if {[info tclversion] >= 8.1} {
Keith> + set expr {([\[\]\$])}
Keith> + } else {
Keith> + set expr {([][$])}
Keith> + }
Keith> + regsub -all -- $expr $commands \
Keith> + {[format "\\%c" [scan {\1} %c x; set x]]} new_commands
This is the part of the patch I don't understand.
Why is this necessary?
Tom