This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: [RFA] source window focus patch
- From: Keith Seitz <keiths at redhat dot com>
- To: "Martin M. Hunt" <hunt at redhat dot com>
- Cc: Insight Mailing List <insight at sources dot redhat dot com>
- Date: Wed, 2 Jan 2002 17:55:01 -0800 (PST)
- Subject: Re: [RFA] source window focus patch
On Wed, 2 Jan 2002, Martin M. Hunt wrote:
> For the last 6 months, the console window has been almost useless due to
> the bug that Keith recently fixed, plus another nasty bug that keeps taking
> thefocus away from the console window and puts it on the source window. This
> patch should fix that.
Ok, I know that this all stems from Nick Duffek's change on 2001-03-01,
and I think that this patch is worth a try. We'll have to watch for focus
loss inside the source window while stepping.
If anyone notices any focus problems with the source window, please let us
know.
Thanks, Martin.
Keith
>
> --
> Martin Hunt
> GDB Engineer
> Red Hat, Inc.
>
> 2002-01-02 Martin M. Hunt <hunt@redhat.com>
>
> * library/srctextwin.itb: Set focus on srcwin only
> if another window doesn't have the focus.
>
> Index: srctextwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
> retrieving revision 1.28
> diff -u -p -r1.28 srctextwin.itb
> --- srctextwin.itb 2001/10/04 15:01:36 1.28
> +++ srctextwin.itb 2002/01/03 01:08:27
> @@ -681,8 +681,10 @@ body SrcTextWin::config_win {win {asm S}
> bind_plain_key $win Up [list %W yview scroll -1 units]
> bind_plain_key $win Down [list %W yview scroll +1 units]
>
> - # Make key bindings usable immediately (without mouse click in window).
> - focus $win
> + # After loading a new file, focus sometimes gets lost
> + # so point it back to this window if it doesn't already
> + # point elsewhere.
> + if {[focus -displayof $win] == ""} {focus $win}
> }
>
> # ------------------------------------------------------------------
>