Re: [RFA] Remove src-font

[Keith Seitz <keiths at redhat dot com>]

On Sat, 2 Mar 2002, Martin M. Hunt wrote:

> src-font is a prehistoric name for the font used by the source window.
> It predates libgui and tcl8.0.  Libgui creates a bunch of font objects for
> us and tracks changes to preferences, so src-font long ago became
> redundant. This patch replaces it with its equivalent, "global/fixed".

Only one question...

> Index: console.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/console.itb,v
> retrieving revision 1.19
> diff -u -p -r1.19 console.itb
> --- console.itb	2002/01/18 17:24:29	1.19
> +++ console.itb	2002/03/03 06:03:16
> @@ -20,18 +20,6 @@ body Console::constructor {args} {
>    _build_win
>    eval itk_initialize $args
>    add_hook gdb_no_inferior_hook [list $this idle dummy]
> -
> -  # Right now the preferences window directly uses preference
> -  # variables.  This means that if we track the preference changes
> -  # here, things will appear weird to the user -- the console window
> -  # will change before the user chooses Accpet in the prefs window.
> -  # Until the preference window is fixed we can't enable this
> -  # dynamic tracking.  FIXME.
> -  # foreach option {gdb/console/wrap gdb/console/prompt_fg \
> -  #		    gdb/console/error_fg gdb/console/font} {
> -  #  pref add_hook $option [code $this _update_option]
> -  # }
> -

I'd like to update this comment and keep it in (along with the commented
out Console::_update_option). I believe that you fixed the prefs window
glitch, so now it is just a matter of re-doing the preferences so that we
can either add preferences dynamically or we need to update the
preferences to contain the options specified in this. I know I would
certainly like to change a few of these (particularly the wrap one).

Otherwise, please check this all in. Thanks.
Keith