This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: get_frame_block getting patched...?


> The get_frame_block mismatch has made insight unbuildable for a few days now.
> Should I hold my breath on a patch, or roll back the sources to March?

Puzzling.  I know Keith committed some fixes because we both posted at 
the same time.   Hmm, yes, it doesn't build.  Dig, dig.  Turns out there 
was a missing Makefile dependency that hid the attached and in the 
confusion didn't get in.

Committed as obvious.

> I ask because I don't know what the development rules are for GDB and
> Insight.  In GCC-land, we'd have reverted the patch by now.  :-)

You mean ``:-^'' right?  As a rule of thumb, GDB and/or Insight are 
stable build and work.  Now about GCC? ;-)

Andrew
Index: gdb/gdbtk/ChangeLog
2002-04-08  Andrew Cagney  <ac131313@redhat.com>

	* generic/gdbtk-wrapper.c (wrap_get_frame_block): 

Index: gdb/gdbtk/generic/gdbtk-wrapper.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.c,v
retrieving revision 1.5
diff -u -r1.5 gdbtk-wrapper.c
--- gdb/gdbtk/generic/gdbtk-wrapper.c	7 Feb 2002 05:05:06 -0000	1.5
+++ gdb/gdbtk/generic/gdbtk-wrapper.c	9 Apr 2002 01:38:04 -0000
@@ -668,7 +668,7 @@
   struct frame_info *fi;
 
   fi = (struct frame_info *) (*args)->args[0];
-  (*args)->result = (char *) get_frame_block (fi);
+  (*args)->result = (char *) get_frame_block (fi, NULL);
 
   return 1;
 }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]