This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Why is PASCAL undefined in win/tclWinPort.h?


On Thu, 12 Sep 2002, Mo DeJong wrote:

Hmm. Actually, I don't think I alone can approve this... Hm, well, ok, 
src/MAINTAINERS says "insight" for tcl/, tk/, itcl/, libgui/, and tix/, so 
I guess I can.

Committed.

> 2002-09-12  Mo DeJong  <supermo@bayarea.net>
> 
> 	* win/tclWin32Dll.c (DllMain): Remove unused os
> 	variable since VC++ treats warnings as errors
> 	when compiling with symbols.
> 	* win/tclWinPort.h: Remove undefine of PASCAL
> 	symbol added on 2001-09-12. It caused
> 	crashing problems with sockets.
> 
> Index: win/tclWin32Dll.c
> ===================================================================
> RCS file: /cvs/src/src/tcl/win/tclWin32Dll.c,v
> retrieving revision 1.4
> diff -u -r1.4 tclWin32Dll.c
> --- win/tclWin32Dll.c	9 Sep 2001 23:56:10 -0000	1.4
> +++ win/tclWin32Dll.c	13 Sep 2002 00:32:23 -0000
> @@ -190,8 +190,6 @@
>      DWORD reason;		/* Reason this function is being called. */
>      LPVOID reserved;		/* Not used. */
>  {
> -    OSVERSIONINFO os;
> -
>      /* CYGNUS LOCAL */
>  #ifdef __CYGWIN__0
>      /* Cygwin requires the impure data pointer to be initialized
> Index: win/tclWinPort.h
> ===================================================================
> RCS file: /cvs/src/src/tcl/win/tclWinPort.h,v
> retrieving revision 1.6
> diff -u -r1.6 tclWinPort.h
> --- win/tclWinPort.h	13 Sep 2001 18:27:55 -0000	1.6
> +++ win/tclWinPort.h	13 Sep 2002 00:32:23 -0000
> @@ -73,10 +73,6 @@
>  #include <windows.h>
>  #undef WIN32_LEAN_AND_MEAN
>  
> -#ifdef _MSC_VER
> -#define PASCAL
> -#endif
> -
>  #ifdef BUILD_tcl
>  # undef TCL_STORAGE_CLASS
>  # define TCL_STORAGE_CLASS DLLEXPORT
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]