This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Modal Dialogs lose grab when comboboxes are used


Ouch!  There is indeed a line missing from my patch.
I've committed the attached.

Thanks for spotting it Martin.

Fernando

Martin M. Hunt wrote:
Fernando,

Did you forget something? This breaks all the comboboxes on Insight. Looks like grabstatus is not initialized. Doing that gets things working for me, but I did not look very closely.



--
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9
Index: library/combobox.tcl
===================================================================
RCS file: /cvs/src/src/libgui/library/combobox.tcl,v
retrieving revision 1.4
retrieving revision 1.5
diff -c -p -r1.4 -r1.5
*** library/combobox.tcl	20 Sep 2002 17:38:52 -0000	1.4
--- library/combobox.tcl	25 Sep 2002 05:01:21 -0000	1.5
*************** proc ::combobox::widgetProc {w command a
*** 792,797 ****
--- 792,798 ----
  	    # *gasp* do a global grab!!! Mom always told not to
  	    # do things like this... :-)
  	    set grablist [grab current]
+ 	    set grabstatus {}
  	    foreach grabitem $grablist {
  		lappend grabstatus [grab status $grabitem]
  	    }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]