This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
[PATCH] Don't update registers with no valid frame
- From: Keith Seitz <keiths at redhat dot com>
- To: "insight at sources dot redhat dot com" <insight at sources dot redhat dot com>
- Date: 11 Feb 2003 16:44:10 -0800
- Subject: [PATCH] Don't update registers with no valid frame
- Organization:
Hi,
This patch should fix a recent internal_error problem that has crept up
in recent days. Try opening the Register Window with no process. Oops.
Keith
ChangeLog
2003-02-11 Keith R Seitz <keiths@redhat.com>
* generic/gdbtk-register.c (register_changed_p): If the selected
frame is NULL, do not call frame_register_read, since that will
now cause an internal error.
Index: gdbtk/generic/gdbtk-register.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v
retrieving revision 1.14
diff -u -p -r1.14 gdbtk-register.c
--- gdbtk/generic/gdbtk-register.c 11 Feb 2003 16:08:38 -0000 1.14
+++ gdbtk/generic/gdbtk-register.c 12 Feb 2003 00:36:34 -0000
@@ -437,7 +437,8 @@ register_changed_p (int regnum, void *ar
{
char *raw_buffer = alloca (MAX_REGISTER_RAW_SIZE);
- if (!frame_register_read (deprecated_selected_frame, regnum, raw_buffer))
+ if (deprecated_selected_frame == NULL
+ || !frame_register_read (deprecated_selected_frame, regnum, raw_buffer))
return;
if (memcmp (&old_regs[regnum * MAX_REGISTER_RAW_SIZE], raw_buffer,