This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
tcl8.4.1 - tclWinInit - AppendEnvironment()
- From: Patrick Samson <p_samson at yahoo dot com>
- To: insight at sources dot redhat dot com
- Date: Wed, 14 Jan 2004 00:43:57 -0800 (PST)
- Subject: tcl8.4.1 - tclWinInit - AppendEnvironment()
This function was designed at a time when the
parameter
'lib' was fed with a value such as "lib/tclX.Y",
so there is two times a "lib + 4" pointer to extract
the "tclX.Y" part.
But the value has changed to "share/tclX.Y" in
TclpInitLibraryPath(), and now lib + 4 points to
"/tclX.Y", which is of no use !
The caller and the calling should be accorded.
As "lib + a number" is a poor coding design (this
issue
shows how fragile it is), I suggest to change it
entirely to a more robust one (RedHat/Cygwin people to
inform developers at sourceforge?).
I also have a doubt about this part of code, at the
end:
} else {
objPtr = Tcl_NewStringObj(buf, -1);
}
Tcl_ListObjAppendElement(NULL, pathPtr, objPtr);
In my understanding, it means that the same object is
appended a second time. Am I wrong?
__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus