This is the mail archive of the insight@sourceware.org mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] INSIGHT_FORCE_READ_PREFERENCES


Andrew STUBBS wrote:

Therefore, here is a patch for option 2.

Looks good.


I have used the variable name INSIGHT_FORCE_READ_PREFERENCES. I prefer INSIGHT to GDBTK because users will know what that means.

Yes, I really should switch all the GDBTK_* ones over, too. :-)


If the patch is OK, will I be permitted to check it in myself? I have 'write after approval' permission for GDB, but I know that doesn't extend to other projects (GCC, Binutils etc.) but I'm not sure about Insight. If not, it would be easier for somebody else to commit this one little patch for me.

AFAIAC, having write privileges to gdb is good enough. You should check in your patch. Don't forget to update the environment variables section in the README.


Thanks!
Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]