This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: Patch ping
- From: Keith Seitz <keiths at redhat dot com>
- To: Andrew STUBBS <andrew dot stubbs at st dot com>
- Cc: insight at sourceware dot org
- Date: Mon, 23 Jan 2006 17:35:53 -0800
- Subject: Re: Patch ping
- References: <43D518C6.2090309@st.com>
Andrew STUBBS wrote:
I posted three trivial patches to this list nearly two weeks ago and
have received no response at all.
My bad, sorry.
I've checked in all your changes, but I made a slight clean-up to the
memprefs.itb patch. I've attached the diff between your patch and mine
(committed).
Thanks!
Keith
ChangeLog
2006-01-23 Keith Seitz <keiths@redhat.com>
From Andrew Stubbs <andrew.stubbs@st.com>:
* library/help/source.html: Add entries for the missing menu
commands.
2006-01-23 Keith Seitz <keiths@redhat.com>
From Andrew Stubbs <andrew.stubbs@st.com>:
* library/mempref.itb (MemPref::constructor): Allow the Byte
Per Row
combo box to accept arbitrary values.
(MemPref::set_bytes_per_row): Validate the new value; reject
invalid
entries and round up to a multiple of the word size.
(MemPref::apply): Read the value from the text box even if the user
has not pressed return.
(MemPref::enable_format): Ensure the bytes per row value is
still valid.
(MemPref::disable_format): Likewise.
* library/mempref.ith (MemPref): Add $gbprlist.
* library/help/memory.html: Update.
2006-01-23 Keith Seitz <keiths@redhat.com>
From Andrew Stubbs <andrew.stubbs@st.com>:
* library/helpviewer.tcl (open_help): Add firefox and opera to the
browser list used to display help.
*** yours 2006-01-23 17:10:24.000000000 -0800
--- mine 2006-01-23 17:13:53.000000000 -0800
*** 43,64 ****
+ if {[expr {$gbpr > 150}]} {set gbpr 150}
+
+ # Insert the value into the combo box list, if it isn't there already.
! + set found 0
! + foreach item $gbprlist {
! + if {$item == $gbpr} {
! + set found 1
! + }
! + }
! + if {[expr {$found == 0}]} {
+ lappend gbprlist $gbpr
+ $Widgets(b-bytes_per_row) list insert end $gbpr
+ }
+
+ set s $gsize
! + if {[expr {$s == 3}]} {set s 4}
! + if {[expr {$s == 5}]} {set s 8}
+ set rem [expr {$gbpr % $s}]
! + if {[expr {$rem != 0}]} {
+ # The bytes-per-row is not a multiple of the size.
+ set gbpr [expr {$gbpr + ($s - $rem)}]
+ }
--- 53,70 ----
+ if {[expr {$gbpr > 150}]} {set gbpr 150}
+
+ # Insert the value into the combo box list, if it isn't there already.
! + set found [lsearch $gbprlist $gbpr]
! +
! + if {$found == -1} {
+ lappend gbprlist $gbpr
+ $Widgets(b-bytes_per_row) list insert end $gbpr
+ }
+
+ set s $gsize
! + if {$s == 3} {set s 4}
! + if {$s == 5} {set s 8}
+ set rem [expr {$gbpr % $s}]
! + if {$rem != 0} {
+ # The bytes-per-row is not a multiple of the size.
+ set gbpr [expr {$gbpr + ($s - $rem)}]
+ }