This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [patch] cygwin -Werror build fix
- From: Christopher Faylor <me at cgf dot cx>
- To: Brian Dessent <brian at dessent dot net>, insight at sources dot redhat dot com
- Date: Wed, 29 Mar 2006 01:00:36 -0500
- Subject: Re: [patch] cygwin -Werror build fix
- References: <4429DB24.A8C459B9@dessent.net>
On Tue, Mar 28, 2006 at 04:56:04PM -0800, Brian Dessent wrote:
>
>This fixes building with -Werror (which is now enabled by default) under Cygwin.
>
>2006-03-28 Brian Dessent <brian@dessent.net>
>
> * generic/gdbtk-cmds.c: Include sys/cygwin.h if __CYGWIN__ defined.
>Index: generic/gdbtk-cmds.c
>===================================================================
>RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
>retrieving revision 1.91
>diff -u -p -r1.91 gdbtk-cmds.c
>--- generic/gdbtk-cmds.c 23 Dec 2005 18:23:15 -0000 1.91
>+++ generic/gdbtk-cmds.c 29 Mar 2006 00:51:15 -0000
>@@ -64,6 +64,10 @@
> #include "dis-asm.h"
> #include "gdbcmd.h"
>
>+#ifdef __CYGWIN__
>+#include <sys/cygwin.h> /* for cygwin32_conv_to_full_win32_path */
>+#endif
>+
> #ifdef HAVE_CTYPE_H
> #include <ctype.h> /* for isprint() */
> #endif
That looks like an obvious fix to me. Please check it in.
In fact, if this function is still being referred to as
cygwin32_conv_to_full_win32_path then I'd appreciate it if you would change the
cygwin32 -> cygwin.
cgf