This is the mail archive of the insight@sourceware.org mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't call Insight hooks when not appropriate


Daniel Jacobowitz wrote:
On Wed, Mar 29, 2006 at 04:55:35PM +0100, Andrew STUBBS wrote:
Daniel Jacobowitz wrote:
It looked much like what you've posted below, except more thorough
(e.g. you missed defaulted_query).  I can see the whole patch in the
list archives, so I wonder if your mail client ate it.
I see what's happened; there's a form-feed, or something, in it and that has caused the confusion.

Sorry, I'll try your patch properly.

D'oh! Thanks. A lot of GDB code uses those for page breaks.

Yes, it is irritating, but I'm sure somebody likes them.


I have now tested your full patch. I could not get it to compile without adding 'caution' to top.h and including top.h in utils.c.

With that one change it does what I want. Thanks.

One small query: defaulted_query() used to return def_value, but now always returns 1. This does not seem to be the same thing. The new text is identical to that in query(), which smells like a paste-o to me.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]