This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>, "Maciej W. Rozycki" <macro at mips dot com>, insight at sourceware dot org
- Date: Thu, 10 May 2007 11:29:50 -0400
- Subject: Re: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+
- References: <Pine.LNX.4.61.0705101235020.29962@perivale.mips.com>
On Thu, May 10, 2007 at 12:42:39PM +0100, Maciej W. Rozycki wrote:
>Hello,
>
> This change:
>
>2006-11-30 Christopher Faylor <cgf@timesys.com>
>
> * win/tclWinPipe.c (TclpCreateProcess): Call cygwin-specific routine to
> set up windows environment.
>
>broke building on versions of Cygwin predating 1.15.20. The
>CW_SYNC_WINENV internal call was not previously available. Here is a fix.
There is no such thing as Cygwin 1.15.20. I don't know exactly when this was
applied but I would just avoid referring to the exact version of Cygwin in the
ChangeLog.
>2007-05-10 Maciej W. Rozycki <macro@mips.com>
>
> * win/tclWinPipe.c (TclpCreateProcess): Only use CW_SYNC_WINENV
> for Cygwin 1.15.20+.
>
> OK to apply?
No, sorry. If you are going to be testing versions like this then please
use CYGWIN_VERSION_USER_API_VERSION_COMBINED.
cgf