This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
[PATCH] Fix find_and_open_source link error
- From: Keith Seitz <keiths at redhat dot com>
- To: insight <insight at sourceware dot org>
- Date: Mon, 21 Apr 2008 13:10:34 -0700
- Subject: [PATCH] Fix find_and_open_source link error
Hi,
A recent change in gdb has rendered a function invisible to insight, so
I've found a suitable replacement and committed the attached patch.
Keith
ChangeLog
2008-04-21 Keith Seitz <keiths@redhat.com>
* generic/gdbtk-cmds.c (symtab_to_filename): Call gdb's
open_source_file instead of find_and_open_source.
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.98
diff -u -p -r1.98 gdbtk-cmds.c
--- generic/gdbtk-cmds.c 3 Mar 2008 23:25:03 -0000 1.98
+++ generic/gdbtk-cmds.c 21 Apr 2008 20:14:30 -0000
@@ -1,5 +1,5 @@
/* Tcl/Tk command definitions for Insight.
- Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2007
+ Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2007, 2008
Free Software Foundation, Inc.
Written by Stu Grossman <grossman@cygnus.com> of Cygnus Support.
@@ -3004,13 +3004,9 @@ gdb_CA_to_TAS (ClientData clientData, Tc
* with something similar, but different enough to break
* Insight.
*/
-int find_and_open_source (struct objfile *objfile, const char *filename,
- const char *dirname, char **fullname);
-
char *
symtab_to_filename (struct symtab *s)
{
-
int r;
if (!s)
@@ -3018,8 +3014,7 @@ symtab_to_filename (struct symtab *s)
/* Don't check s->fullname here, the file could have been
deleted/moved/..., look for it again */
- r = find_and_open_source (s->objfile, s->filename, s->dirname,
- &s->fullname);
+ r = open_source_file (s);
if (r)
close (r);