This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: gdb/gdbtk/generic/gdbtk-stack.c - fail due to strict aliasing
- From: Martin Rakhmanov <rakhmanov dot martin at gmail dot com>
- To: Alon Bar-Lev <alon dot barlev at gmail dot com>
- Cc: insight at sourceware dot org
- Date: Sun, 26 Oct 2008 20:13:48 +0300
- Subject: Re: gdb/gdbtk/generic/gdbtk-stack.c - fail due to strict aliasing
- References: <200810260107.31955.alon.barlev@gmail.com>
This allows to compile currently available snapshot
(ftp://sourceware.org/pub/insight/snapshots/current/insight-weekly-6.8.50-20081021-tar.bz2)
but again does not fix problem with running insight on Fedora 9: the
snapshot ships with old tcl/tk versions and uses them.
Thanks
Martin
Alon Bar-Lev wrote:
Hello,
Reported as binutils bug#6986 [1]
arguments = *(int*) &clientData;
Gets strict aliasing warning that escalate to error and fails build.
Attached a simple temp fix against head.
But the apparently the original has some issue too.
Regards,
Alon Bar-Lev.
------- Additional Comment #2 From Andreas Schwab 2008-10-25 22:53 -------
Neither gdb nor gdbtk are part of binutils. And the patch is as broken as the
original code, it still fails on big-endian 64-bit architectures. Please
report that to the insight mailinglist.
[1] http://sourceware.org/bugzilla/show_bug.cgi?id=6986
---
Index: gdb/gdbtk/generic/gdbtk-stack.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v
retrieving revision 1.29
diff -u -B -r1.29 gdbtk-stack.c
--- gdb/gdbtk/generic/gdbtk-stack.c 2 Sep 2008 17:29:23 -0000 1.29
+++ gdb/gdbtk/generic/gdbtk-stack.c 25 Oct 2008 22:28:12 -0000
@@ -285,7 +285,10 @@
return TCL_ERROR;
}
- arguments = *(int*) &clientData;
+{
+ void *p = &clientData;
+ arguments = *(int*) p;
+}
/* Initialize the result pointer to an empty list. */