This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [PATCH] Remove deprecated access to tcl internal variables
- From: Keith Seitz <keiths at redhat dot com>
- To: Roland Schwingel <roland at onevision dot com>
- Cc: insight at sourceware dot org
- Date: Tue, 27 Mar 2012 07:44:54 -0700
- Subject: Re: [PATCH] Remove deprecated access to tcl internal variables
- References: <4F716889.2080603@onevision.com>
On 03/27/2012 12:13 AM, Roland Schwingel wrote:
Sorry... Sometimes it is hard to switch between the styles. I surely
want to follow the GCS when submitting patches. Our company style is
just (in some areas) vice versa.
Not a problem -- it happens to everyone. :-)
If you give the ok to my patch(es) I can also
do these final reformatting during commit.
That will be best/easiest. One other thing I noticed:
> else
> - actual_len = strlen (gdbtk_interp->result);
> + {
Here ^
> + const char *tclResult = Tcl_GetStringResult(gdbtk_interp);
> + actual_len = strlen (tclResult);
>
> /* Truncate the string if it is too big for the caller's
buffer. */
> if (actual_len >= sizeof_buf)
> actual_len = sizeof_buf - 1;
>
> - memcpy (buf, gdbtk_interp->result, actual_len);
> + memcpy (buf,tclResult, actual_len);
> buf[actual_len] = '\0';
> return actual_len;
> + }
> }
and here^ the identation level is off. Please adjust to follow the rest
of the code. [These should be emacs-default indentations IIRC.]
I did not change behaviour here Keith. gdbtk_read() behaves the same as
before it just takes a small shortcut in case gdbtk_console_read has failed
(for some reasons).
Yes, you are right. I completely missed that. In any case, please add a
ChangeLog entry for it, adjust the two formatting/CS discrepancies and
this patch is good to go in.
Thanks!
Keith