This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [PATCH] Allow onlinehelp to work on native windows
- From: Roland Schwingel <roland at onevision dot com>
- To: Keith Seitz <keiths at redhat dot com>, insight at sourceware dot org
- Date: Fri, 30 Mar 2012 09:08:37 +0200
- Subject: Re: [PATCH] Allow onlinehelp to work on native windows
Hi Keith,
> > * generic/gdbtk.c: (gdbtk_init): Move call to
> ide_create_shell_execute_command
> > to generic windows section.
>
> This line is too long. Please wrap after "call". [We try to keep line
> lengths < 80 characters.]
Rewrapped the Changelog entry.
> > Any comments? Is this ok?
>
> Ok with that change.
In another email today you asked me to adapt copyright years on all
files I touch. In gdbtk.c the years have been also out of sync I
corrected that too and mentioned it in the changelog.
The change is now committed.
Thanks for taking a look,
Roland