This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
RE: [PATCH] Add missing prototype in gdbtk.c
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Keith Seitz'" <keiths at redhat dot com>, "'Roland Schwingel'" <roland at onevision dot com>
- Cc: <insight at sourceware dot org>
- Date: Fri, 30 Mar 2012 15:31:24 +0200
- Subject: RE: [PATCH] Add missing prototype in gdbtk.c
- References: <4F67221F.2020906@onevision.com> <4F74E9F1.20804@redhat.com> <000701cd0e75$5e028b80$1a07a280$@muller@ics-cnrs.unistra.fr> <4F75B0A9.1030609@redhat.com>
>> Prototypes apparently require (void) instead of ().
>
>That's interesting...
>
>> The following patch fixes the problem for mingw32,
>>
>> Is this patch OK?
>>
>
>Sure, you could consider a clean-up like that obvious. [I try to use the
same "rules" gdb uses. It's what I'm >used to.]
>
>Thank you, Pierre!
I wasn't sure about the fact that this is a real
Prototype requirement or not, so I wanted to ask anyway...
Patch committed.
Roland, could you please confirm that
this also works for mingw64.
By the way, I got a working insight for mingw32,
which I was unable to get for a lllloooonnngggg time!
A really big thank to Roland for this!
Pierre
PS: I treid to compiled a mingw64 version of insight,
but I get failures here:
make[1]: Entering directory
`/usr/local/src/gdbcvs/build-insight-mingw64/tcl'
make[2]: Entering directory
`/usr/local/src/gdbcvs/build-insight-mingw64/tcl/win'
x86_64-w64-mingw32-gcc -c -gstabs+ -O0 -D__USE_MINGW_ACCESS -Wall
-Wconversion -I"../../../src/tcl/win/../generic" -I"
../../../src/tcl/win" -mwin32 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\"
-DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -
DPACKAGE_BUGREPORT=\"\" -DHAVE_NO_SEH=1 -DSTDC_HEADERS=1
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHA
VE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DBUILD_tcl
../../../src/tcl/win/../generic/tclCmdAH.c -o tclCmdAH.o
../../../src/tcl/win/../generic/tclCmdAH.c: In function 'Tcl_FileObjCmd':
../../../src/tcl/win/../generic/tclCmdAH.c:827:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:827:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:921:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:921:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:935:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:935:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:1050:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:1050:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:1063:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:1063:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:1138:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:1138:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:1222:4: warning: conversion to
'size_t' from 'int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:1258:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:1258:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:1279:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:1279:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c:1348:18: error: storage size of
'buf' isn't known
../../../src/tcl/win/../generic/tclCmdAH.c:1348:18: warning: unused variable
'buf'
../../../src/tcl/win/../generic/tclCmdAH.c: In function 'StoreStatData':
../../../src/tcl/win/../generic/tclCmdAH.c:1514:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1520:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1521:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1522:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1523:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1524:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1528:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1529:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1530:5: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c:1531:36: error: dereferencing
pointer to incomplete type
../../../src/tcl/win/../generic/tclCmdAH.c: In function 'Tcl_ForeachObjCmd':
../../../src/tcl/win/../generic/tclCmdAH.c:1739:2: warning: conversion to
'long long unsigned int' from 'int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:1739:2: warning: conversion to
'unsigned int' from 'long long unsigned int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c:1755:2: warning: conversion to
'long long unsigned int' from 'int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:1755:2: warning: conversion to
'unsigned int' from 'long long unsigned int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c:1756:2: warning: conversion to
'long long unsigned int' from 'int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:1756:2: warning: conversion to
'unsigned int' from 'long long unsigned int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c:1757:2: warning: conversion to
'long long unsigned int' from 'int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:1757:2: warning: conversion to
'unsigned int' from 'long long unsigned int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c:1758:2: warning: conversion to
'long long unsigned int' from 'int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:1758:2: warning: conversion to
'unsigned int' from 'long long unsigned int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c:1759:2: warning: conversion to
'long long unsigned int' from 'int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:1759:2: warning: conversion to
'unsigned int' from 'long long unsigned int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c: In function 'Tcl_FormatObjCmd':
../../../src/tcl/win/../generic/tclCmdAH.c:2028:6: warning: conversion to
'int' from 'long long int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c:2058:6: warning: conversion to
'int' from 'long unsigned int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:2098:6: warning: conversion to
'int' from 'long unsigned int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:2141:6: warning: conversion to
'int' from 'long unsigned int' may change the sign of the result
../../../src/tcl/win/../generic/tclCmdAH.c:2230:3: warning: conversion to
'int' from 'long long int' may alter its value
../../../src/tcl/win/../generic/tclCmdAH.c:2346:7: warning: conversion to
'int' from 'long long int' may alter its value
Makefile:423: recipe for target `tclCmdAH.o' failed
make[2]: *** [tclCmdAH.o] Error 1
make[2]: Leaving directory
`/usr/local/src/gdbcvs/build-insight-mingw64/tcl/win'
Makefile:15: recipe for target `all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/local/src/gdbcvs/build-insight-mingw64/tcl'
Makefile:7209: recipe for target `all-tcl' failed
make: *** [all-tcl] Error 2