This is the mail archive of the insight@sourceware.org mailing list for the Insight project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [PATCH] fix error sending signal to dead process

From: "Patrick Monnerat" <Patrick dot Monnerat at datasphere dot ch>
To: "Keith Seitz" <keiths at redhat dot com>
Cc: <insight at sourceware dot org>
Date: Thu, 19 Apr 2012 17:19:02 +0200
Subject: RE: [PATCH] fix error sending signal to dead process
References: <AB5E58B87EB73C46A38073D8F459F113D9F882@dataspheresrv01> <4F8F5AAD.9050207@redhat.com>

Keith Seitz wrote:

> There should be spaces between function names and opening parenthesis.

> [Yeah, it's rather lame, but it is GNU coding standard. Insight
follows GDB's conventions.]

> ChangeLog entry?

The new attached patch fixes both of your remarks. It has been made
against today's cvs snapshot.

> [Aside: Eew. I can't believe Tcl_Eval is still being used!]

Well... I'm not enough involved in insight's guts and tcl to share your
estonishment. You're probably right. But I can say at least this call is
clear enough to understand what's happening :-)
In fact I'm only the insight's packager for Fedora.

Thanks for your help.
Cheers,
Patrick

Attachment: insight-7.4.50-sig2dead.patch
Description: insight-7.4.50-sig2dead.patch

Follow-Ups:
- Re: [PATCH] fix error sending signal to dead process
  - From: Keith Seitz

References:
- [PATCH] fix error sending signal to dead process
  - From: Patrick Monnerat
- Re: [PATCH] fix error sending signal to dead process
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]