This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [PATCH] Remove use of deprecated_command_loop_hook
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: insight at sourceware dot org, "Keith Seitz" <keiths at redhat dot com>
- Date: Thu, 5 Sep 2013 14:00:00 +0100
- Subject: Re: [PATCH] Remove use of deprecated_command_loop_hook
- Authentication-results: sourceware.org; auth=none
- References: <5215571A dot 3040403 at broadcom dot com> <5227B183 dot 2060702 at redhat dot com> <52287F7D dot 6040308 at broadcom dot com>
On 05/09/2013 1:56 PM, Andrew Burgess wrote:
> On 04/09/2013 11:17 PM, Keith Seitz wrote:
>> Sorry for the delay on this: I've been out of the office for a bit.
>>
>> On 08/21/2013 05:11 PM, Andrew Burgess wrote:
>>> I have commit access to gdb, but I have no idea if that extends to
>>> gdb/gdbtk, and even if it did I obviously wouldn't commit without
>>> approval :)
>>
>> I handle insight as an extension of gdb. Pretty much the same policies
>> w.r.t. obvious patches, build errors, etc. If you have
>> commit-after-approval on gdb, you do here, too.
>>
>>> What do you think?
>>
>> I actually wonder how something this simple has been overlooked for so
>> long? Well, actually, I do know. Thank you for thinking about us!
>>
>> Please commit.
>
> Committed.
Gah! The date I used in the ChangeLog was the original date I posted the
patch, not the date I actually made the commit.
Given that this date is still later than the previous change in the file
I'm going to leave it alone, unless I'm asked to change it.
Sorry for that.
Andrew