Use jikes for kawa problem and Re: bug/patch for kawa/standard/object.java

[Vladimir Tsichevski <wowa at jet dot msk dot su>]

Hi Per,

Per Bothner wrote:

> Vladimir Tsichevski wrote:
>
> > Hi,
> >
> > object with methods cannot currently be declared with define-syntax 
> > mechanism. You get "missing method name"
> > error message if you try to.
> >
> > Below is the patch which (hopefully) cures this problem.
>
>
> Good job getting this far. The patch is basically correct,
> but it doesn't go far enough.
> Co-incidentally (?), I was looking the bug Chris Dean
> reported, and I came up with the attached patch.

Ok,

here then is another bunch of notes/problems/patches:

==========================================================================
make check failed if you configure jikes as Java compiler. Failed 
operation was

CLASSPATH=..:. jikes -g ./SimpleB.java -d .

reason: CLASSPATH must explicitly include Java runtime library rt.jar

suggestion: improve configure.in to locate Java runtime library and
change the Makefile.am's corrspondingly

The attached patch compile-with-jikes should solve this.
The patch includes also fix for typo in configure.in . Was:

AC_ARG_WITH(sax2,
[ --with-sax2 Assume AWT is available])

==========================================================================
Bug in NumberCompare

(let((a <int> 1))
(= 1 a))

(Sorry, I'm not shure whether I already reported it earlier).

see the bug-in-NumberCompare patch
==========================================================================
Minor problem: *.java source files in testsuite/ subdir have empty
package. This makes it harder to compile kawa with such instruments as 
Borland JBuilder

Solution: either move all the kawa sources to subdirectory named say 
src/ , so we can use it as
reliable source base, or use package name testsuite for all Java files 
it testsuite directory.

==========================================================================
Minor problem making documentation: version.texi file is not auto-generated

Making all in doc
make[1]: ???? ? ??????? `/jet/wowa/build/kawa_patched/doc'
/bin/sh /jet/wowa/build/kawa_patched/missing --run makeinfo -I . \
-o kawa.info `test -f 'kawa.texi' || echo './'`kawa.texi
kawa.texi:11: @include `version.texi': No such file or directory.
==========================================================================
Minor problem:
configuration: Makefiles's are not rebuilt automatically when
Makefile.am changes as it should be
==========================================================================
make check results in an error:

FAIL: "declare namespace File='class:java.io.File'
define function make-file ($x) {File:new($x)}
define function parent ($x) {java.io.File:getParent($x)}
parent(make-file('dir/mine.txt'))" evaluated to "*** syntax error - 
<string>:2:33: warning - no definitely applicable method `<init>' in 
java.io.File" but expected "dir"


reason: failure to compile File:new() procedure
==========================================================================

Regards,
Vladimir


Index: Make-rules
===================================================================
RCS file: /cvs/kawa/kawa/Make-rules,v
retrieving revision 1.14
diff -r1.14 Make-rules
4,5c4,5
< JAVACFLAGS = 
< CLASSPATH_ENV = CLASSPATH=$(JAVAROOT)@pathsep at $(srcdir)@filesep at $(JAVAROOT)@pathsep at $$CLASSPATH
---
> JAVACFLAGS = 
> CLASSPATH_ENV = CLASSPATH=$(JAVAROOT)@pathsep at $(srcdir)@filesep at $(JAVAROOT)@pathsep at $$CLASSPATH:@JAVART@
Index: configure.in
===================================================================
RCS file: /cvs/kawa/kawa/configure.in,v
retrieving revision 1.97
diff -r1.97 configure.in
7c7
< AM_INIT_AUTOMAKE(kawa, 1.7beta1) dnl Also update build.xml.
---
> AM_INIT_AUTOMAKE(kawa, 1.7beta1pl1) dnl Also update build.xml.
22a23,28
> AC_ARG_WITH(jikes,
>   [  --with-jikes            Compile Kawa using jikes (IBM Compiler for Java)])
> 
> AC_ARG_WITH(javart,
>   [  --with-java-runtime     Java runtime libraries (required for jikes)])
> 
46c52
<   [  --with-sax2             Assume AWT is available])
---
>   [  --with-sax2             Assume SAX is available])
67a74,99
> 
> if test "${with_jikes}" = yes ; then
>    JAVAC=jikes
>    if test -n "$with-java-runtime" ; then
>      JAVART=$with_java_runtime
>    else
>      JAVART=$JAVA_HOME/jre/lib/rt.jar
>    fi
>    if ! test -f "$JAVART" ; then
>       AC_MSG_ERROR([
> ***
> Use --with-java-runtime option to specify path to standard Java
> library. This must be explicitly specified in order to compile kawa
> with jikes compiler. For example:
> 
> ./configure --with-jikes --with-java-runtime=/usr/java/jre/lib/rt.jar
> ***
> ])
>    fi
> 
>    AC_PATH_PROG(jikes, jikes)
>    if test -n "$jikes"; then
>      JAVAC=$jikes
>    fi
> fi
> AC_SUBST(JAVART)
Index: testsuite/Makefile.am
===================================================================
RCS file: /cvs/kawa/kawa/testsuite/Makefile.am,v
retrieving revision 1.42
diff -r1.42 Makefile.am
90c90
< 	CLASSPATH=..:. $(JAVAC) -g $(srcdir)/SimpleB.java -d .
---
> 	CLASSPATH=..:.:@JAVART@ $(JAVAC) -g $(srcdir)/SimpleB.java -d .
135c135
< 	CLASSPATH=..:. $(JAVAC) -g $(srcdir)/MySAXApp.java -d .
---
> 	CLASSPATH=..:.:@JAVART@ $(JAVAC) -g $(srcdir)/MySAXApp.java -d .
145c145
< 	CLASSPATH=..:. $(JAVAC) -g -d . $?
---
> 	CLASSPATH=..:.:@JAVART@ $(JAVAC) -g -d . $?

Index: gnu/kawa/functions/NumberCompare.java
===================================================================
RCS file: /cvs/kawa/kawa/gnu/kawa/functions/NumberCompare.java,v
retrieving revision 1.6
diff -r1.6 NumberCompare.java
198c198,199
< 		    mask ^= TRUE_IF_GRT|TRUE_IF_LSS;
---
> 		    if (mask != TRUE_IF_EQU)
> 			mask ^= TRUE_IF_GRT|TRUE_IF_LSS;
223c224,225
< 		mask ^= TRUE_IF_GRT|TRUE_IF_LSS;
---
> 		if (mask != TRUE_IF_EQU)
> 		    mask ^= TRUE_IF_GRT|TRUE_IF_LSS;
236a239,240
> 		  // We never should be here
> 		  // assert(false);