This is the mail archive of the kawa@sourceware.org mailing list for the Kawa project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Hash tables


Jim White wrote:
It's a bug in the Kawa SRFI-69 implementation.  There is some kind of
problem removing the first key, but not the second.

Ooops, yes. I checked in the attached fix. -- --Per Bothner per@bothner.com http://per.bothner.com/
Index: GeneralHashTable.java
===================================================================
--- GeneralHashTable.java	(revision 5998)
+++ GeneralHashTable.java	(working copy)
@@ -142,7 +142,7 @@
 	    if (prev == null)
 	      table[index] = next;
 	    else
-	      prev.next = node;
+	      prev.next = next;
 	    num_bindings--;
 	    return node.getValue();
 	  }
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 5998)
+++ ChangeLog	(working copy)
@@ -1,3 +1,8 @@
+2008-01-16  Per Bothner  <per@bothner.com>
+
+	* GeneralHashTable.java (remove): Fix thinko.
+	Bug reported by daniel.s.terhorst@gmail.com; and jim@pagesmiths.com.
+
 2007-01-06  Per Bothner  <per@bothner.com>
 
 	* PreProcess.java (version_features): Map "java1" etc to

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]