Re: Kawa on Android - unable to use 'for-each' form

[Benny Tsai <benny dot tsai at gmail dot com>]

Here's a tweaked version of PreProcess.java that appears to do the
right thing.  On my system, when run on both Unix and Windows sources,
it produces the same output as the original PreProcess.java when run
on Unix sources.  Only minor changes were needed; I've prefixed each
changed section with a "// MODIFIED" comment.

On Sat, Mar 19, 2011 at 12:42 PM, Benny Tsai <benny.tsai@gmail.com> wrote:
> No problem, I'll give it a go.
>
> On Sat, Mar 19, 2011 at 12:19 PM, Per Bothner <per@bothner.com> wrote:
>> On 03/19/2011 10:39 AM, Benny Tsai wrote:
>>>
>>> Got it! ?The problem is indeed in the Java pre-processing.
>>>
>>> The issue is that when I got the sources from SVN, svn automatically
>>> converted line endings to Windows line endings. ?However, the logic in
>>> gnu/kawa/util/PreProcess.java appears to have been written with Unix
>>> line endings in mind, leading to the pre-processing misbehaving on my
>>> system. ?The sources you sent worked because they retained Unix line
>>> endings.
>>
>> Well, PreProcess.java is *intended* to support Windows line endings,
>> as you can tell from the places where '\r' is used in the code. ?But there
>> is probably some bug, since I haven't tested it on Windows.
>>
>> Would you mind trying to debug PreProcess? ?I really would like
>> to have it work out-of-the-box on Windows. ?Just run PreProcess
>> manually on some sample file that it handles wrong. ?Once you've
>> manually reproduced the problem, you can try simplifying to get
>> create a shorter file so if you add println statements to PreProcess
>> you don't get overwhelmed.
>> --
>> ? ? ? ?--Per Bothner
>> per@bothner.com ? http://per.bothner.com/
>>
>

Attachment: PreProcess.java
Description: Binary data