This is the mail archive of the
kawa@sourceware.org
mailing list for the Kawa project.
Re: Patch: new special form #!native
- From: Per Bothner <per at bothner dot com>
- To: Jamison Hope <jrh at theptrgroup dot com>
- Cc: Kawa mailing list <kawa at sourceware dot org>
- Date: Sun, 02 Oct 2011 09:55:07 -0700
- Subject: Re: Patch: new special form #!native
- References: <340ACB63-D208-4954-9C74-DB5100194B95@theptrgroup.com> <4E84B9DA.30307@bothner.com> <98296395-AD5A-4CA9-9B84-DCE3C7ECB3BB@theptrgroup.com>
Thanks - I checked in your fix.
I also did a modest edit to the manual (kawa.texi - Defining new classes).
On 09/29/2011 11:46 AM, Jamison Hope wrote:
To be honest, I'm really not sure what that section of ClassExp is doing;
I just did a search for isAbstract() and added isNative() calls in the
vicinity assuming that in most cases that would be a reasonable thing to
do.
This section of the code iterates over abstract methods, and then for
each method looks for a defining method. If there is none, we get an error.
In this case native is the opposite of abstract: If there is a non-abstract
method, we've found a match, so there is nothing more to do. I.e. if the
method found is abstract, we have (after some more testing) an error,
but if the method found is native, we're hunky-dory.
Does it otherwise seem like a reasonable addition?
Yup.
--
--Per Bothner
per@bothner.com http://per.bothner.com/