This is the mail archive of the
libc-alpha@sourceware.cygnus.com
mailing list for the glibc project.
Re: wordexp test failure
- To: Andreas Jaeger <aj at suse dot de>
- Subject: Re: wordexp test failure
- From: Geoff Clare <gwc at unisoft dot com>
- Date: Mon, 6 Mar 2000 16:44:29 GMT
- Cc: libc-alpha Mailinglist <libc-alpha at sourceware dot cygnus dot com>
Hi Andreas.
> >> The current glibc 2.2 version from CVS fails make check for wordexp.
> >>
> >> The failing test is:
> >> Test 131 (${var#~root}x): FAILED
> >> Test words: <${var#~root}x>, need retval 0, wordc 1
> >> Got retval 0, wordc 1: </home/ajx>
> >>
> Geoff> Without seeing the code for the test, it's hard to guess what might be
> Geoff> wrong. If you can send me the latest wordexp-test.c I'll investigate.
>
> I'll send them separatly.
Looks like the failing test ended up in the wrong place when my 2.1.2 patch
was applied to the 2.2 version. The patch below moves it to the right place.
Geoff.
--- wordexp-test-2.2.c Mon Mar 6 16:17:00 2000
+++ wordexp-test.c Mon Mar 6 16:30:30 2000
@@ -270,6 +270,17 @@
if (testit (&ts))
++fail;
+
+ ts.retval = 0;
+ ts.env = pw->pw_dir;
+ ts.words = "${var#~root}x";
+ ts.flags = 0;
+ ts.wordc = 1;
+ ts.wordv[0] = "x";
+ ts.ifs = IFS;
+
+ if (testit (&ts))
+ ++fail;
}
/* "~" expands to value of $HOME when HOME is set */
@@ -299,17 +310,6 @@
ts.flags = 0;
ts.wordc = 1;
ts.wordv[0] = pw->pw_dir;
- ts.ifs = IFS;
-
- if (testit (&ts))
- ++fail;
-
- ts.retval = 0;
- ts.env = pw->pw_dir;
- ts.words = "${var#~root}x";
- ts.flags = 0;
- ts.wordc = 1;
- ts.wordv[0] = "x";
ts.ifs = IFS;
if (testit (&ts))
--
Geoff Clare gwc@unisoft.com
UniSoft Limited, London, England. gwc@root.co.uk