This is the mail archive of the
libc-alpha@sourceware.cygnus.com
mailing list for the glibc project.
Re: [patch] alpha madv constants
- To: Richard Henderson <rth at twiddle dot net>
- Subject: Re: [patch] alpha madv constants
- From: Andreas Jaeger <aj at suse dot de>
- Date: 20 Mar 2000 21:42:22 +0100
- Cc: libc-alpha at sourceware dot cygnus dot com
- References: <20000320122401.A14919@twiddle.net>
>>>>> Richard Henderson writes:
> * sysdeps/unix/sysv/linux/alpha/bits/mman.h: Add MADV constants.
Do I understand you correctly that you prefer your patch to mine?
I've send yesterday already a patch for this.
> Index: sysdeps/unix/sysv/linux/alpha/bits/mman.h
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/alpha/bits/mman.h,v
> retrieving revision 1.3
> diff -u -p -d -r1.3 mman.h
> --- mman.h 1998/01/26 22:52:51 1.3
> +++ mman.h 2000/03/20 20:01:54
> @@ -81,3 +81,19 @@
> #ifdef __USE_GNU
> # define MREMAP_MAYMOVE 1
> #endif
> +
> +/* Advice to `madvise'. */
> +#ifdef __USE_BSD
> +# define MADV_NORMAL 0 /* No further special treatment. */
> +# define MADV_RANDOM 1 /* Expect random page references. */
> +# define MADV_SEQUENTIAL 2 /* Expect sequential page references. */
> +# define MADV_WILLNEED 3 /* Will need these pages. */
> +# define MADV_DONTNEED 6 /* Don't need these pages. */
> +#endif
> +
> +/* Not used by Linux, but here to make sure we don't clash with
> + OSF/1 defines. */
> +#if 0 && defined(__USE_BSD)
> +# define MADV_DONTNEED_COMPAT 4 /* Old version? */
> +# define MADV_SPACEAVAIL 5 /* Ensure resources are available. */
> +#endif
I don't think we should include the last lines. This is just a
reminder for the kernel - since Linux doesn't support these, we don't
need to add them in glibc.
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.rhein-neckar.de