This is the mail archive of the libc-alpha@sourceware.cygnus.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [Various] Digested Articles


>>>>> Horst von Brand writes:

Horst> Thorsten Kukuk <kukuk@suse.de> said:
Horst> [...]

>> If you look at the XDR language (Power Programming with RPC, page 72),
>> only one parameter is allowed in the language definition:
>> 
>> procedure:
>> type-ident procedure-ident "("type-ident")" "=" value
>> 
>> 2 Arguments are not possible with this/
>> 
>> I think the bug report is wrong, because myrpc.x conflicts with
>> the XDR language definition.

Horst> A compiler (rpcgen) error message would then be in order...

It does already if you don't use -N:
$ rpcgen  pr1731myprc.x 
   bool MYRPCPROC (string, int) = 1;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pr1731myprc.x, line 4: only one argument is allowed

Thorsten, Sven and myself discussed to disable -N and -M since those
flags are not supported at all with glibc.

Is the appended patch ok?

Andreas

2000-05-18  Andreas Jaeger  <aj@suse.de>

	* sunrpc/rpc_main.c (parseargs): Don't accept -M and -N.
	Closes PR libc/1731.

============================================================
Index: sunrpc/rpc_main.c
--- sunrpc/rpc_main.c	2000/02/20 17:51:34	1.17
+++ sunrpc/rpc_main.c	2000/05/18 08:18:47
@@ -1362,6 +1362,13 @@
   cmd->Scflag = flag['C'];
   cmd->makefileflag = flag['M'];
 
+  if (mtflag || newstyle)
+    {
+      /* glibc doesn't support these flags.  */
+      f_print (stderr,
+	       _("This implementation doesn't support newstyle or MT-safe code!\n"));
+      return (0);
+    }
   if (tirpcflag)
     {
       pmflag = inetdflag ? 0 : 1;    /* pmflag or inetdflag is always TRUE */

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]