Re: [PATCH] Fix recent fmemopen breakage

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

On Sun, 03 Sep 2000, Ulrich Drepper wrote:
> Franz Sirl <Franz.Sirl-kernel@lauterbach.com> writes:
> > 	* libio/fmemopen.c (fmemopen_close): Don't free buffer if we didn't
> > allocate it.
> >
> >
> > 	* linuxthreads/spinlock.h: Warning fix.
>
> Andreas already checked in a patch for fmemopen.  I just checked in
> the spinlock fix.  Thanks.

Thanks.

Just a quick status report for glibc-2.1.93 on PPC, I'm seeing the following 
build warnings (with -DNDEBUG=1) I haven't really checked yet:

make[2]: Entering directory `/home/fsirl/rh70/glibc/BUILD/glibc-2.1.93/assert'
__assert.c: In function `__assert':
__assert.c:24: warning: implicit declaration of function `__assert_fail'

make[2]: Entering directory 
`/home/fsirl/rh70/glibc/BUILD/glibc-2.1.93/sysvipc'
../sysdeps/unix/sysv/linux/msgsnd.c: In function `msgsnd':
../sysdeps/unix/sysv/linux/msgsnd.c:37: warning: passing arg 5 of 
`__syscall_ipc' discards qualifiers from pointer target type
../sysdeps/unix/sysv/linux/shmat.c: In function `shmat':
../sysdeps/unix/sysv/linux/shmat.c:52: warning: passing arg 4 of 
`__syscall_ipc' makes integer from pointer without a cast

Possible bugs (?) I haven't tracked down yet:

- glibc compiled against 2.4 headers running on a 2.4 kernel has a stat() 
problem. Unfortunately 2.4 doesn't work on my machine yet, so I can't test :-(

- xf4 compiled against glibc-2.1.9x headers has problems with gtk+, compiling 
xf4 with gcc-2.95/gcc-2.96 or with __NO_STRING_INLINES makes no difference.
The bug can be shown with the gtk+ "tree" example 
(/usr/doc/gtk+*/examples/tree/ on RedHat style installations), it fails here 
with:

Gdk-ERROR **: BadAccess (attempt to access private resource denied)
  serial 106 error_code 10 request_code 146 minor_code 3

Strangely enough this only happens if the example is run as root, if run as a 
non-root user it succeeds. I hope I can track it down during the next days.

Otherwise, glibc-2.1.93 looks really fine on PPC. Congrats to all the people 
involved!

Franz.