This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: one more tweak for the ISO-2022-CN-EXT converter
- To: Bruno Haible <haible at ilog dot fr>
- Subject: Re: one more tweak for the ISO-2022-CN-EXT converter
- From: Ulrich Drepper <drepper at redhat dot com>
- Date: 24 Sep 2000 15:47:43 -0700
- Cc: libc-alpha at sources dot redhat dot com
- References: <14794.7598.161584.263765@honolulu.ilog.fr>
- Reply-To: drepper at cygnus dot com (Ulrich Drepper)
Bruno Haible <haible@ilog.fr> writes:
> The ISO-2022-CN-EXT converter uses bits 2..17 for its internal state,
> but bits 0..2 are sometimes cleared by the consume_incomplete feature
> (iconv/loop.c:388 and iconv/skeleton.c:591). Currently this feature is
> only enabled by mbrtowc, therefore no bug is visible, but it's still
> dangerous because
> - it's a bad example for other converters,
> - the consume_incomplete feature might be used in other situations in
> the future.
I agree. This is what I intended. I had a bug in there and you fixed
it the one way (meaning, with a shift count of 2). Thanks for the
correction, it's now in.
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------