This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

A patch to use fclass for ia64.


On Fri, Dec 08, 2000 at 04:05:43PM -0800, Richard Henderson wrote:
> On Fri, Dec 08, 2000 at 02:53:11PM -0800, H . J . Lu wrote:
> > Warning: Use of 'mov' may violate WAW dependency 'GR%, % in 1 - 127' 
> > impliedf), specific resource number is 8
> [...]
> > (p7)	fclass.m p7, p8 = farg0, @inf|@neg
> > (p6)	br.ret.sptk.many rp
> > 	;;
> > (p7)	mov ret0 = -1
> > (p8)	mov ret0 = 0
> 
> The assembler isn't good enough to see that control only flows
> to the last two instructions when p7 is true, and thus p7/p8
> are mutex.
> 
> I'd suggest just adding a .pred.rel.mutex note after the
> conditional return.
> 

Thanks. It does the trick.

I am enclosing a patch to use the ia64 fclass intruction.


H.J.
----
2000-12-08  H.J. Lu  <hjl@gnu.org>

	* sysdeps/ia64/fpu/s_isinfl.S: Renamed to ...
	* sysdeps/ia64/fpu/s_isinf.S: This.
	Add a .pred.rel.mutex note to avoid false report.

	* sysdeps/ia64/fpu/s_isnanl.S: Renamed to ...
	* sysdeps/ia64/fpu/s_isnan.S: This.

	* sysdeps/ia64/fpu/s_fpclassify.S: New.
	* sysdeps/ia64/fpu/s_fpclassifyf.S: Likewise.
	* sysdeps/ia64/fpu/s_fpclassifyl.S: Likewise.
	* sysdeps/ia64/fpu/s_isinff.S: Likewise.
	* sysdeps/ia64/fpu/s_isinfl.S: Likewise.
	* sysdeps/ia64/fpu/s_isnanf.S: Likewise.
	* sysdeps/ia64/fpu/s_isnanl.S: Likewise.

Index: sysdeps/ia64/fpu/s_isinfl.S
===================================================================
RCS file: /work/cvs/gnu/glibc/sysdeps/ia64/fpu/s_isinfl.S,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 s_isinfl.S
--- sysdeps/ia64/fpu/s_isinfl.S	2000/11/07 01:29:42	1.1.1.1
+++ sysdeps/ia64/fpu/s_isinfl.S	2000/12/09 00:33:34
@@ -1,47 +1 @@
-/* Test for inf/-inf
-   Copyright (C) 2000 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Jes Sorensen <jes@linuxcare.com>, October 2000.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Library General Public License as
-   published by the Free Software Foundation; either version 2 of the
-   License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Library General Public License for more details.
-
-   You should have received a copy of the GNU Library General Public
-   License along with the GNU C Library; see the file COPYING.LIB.  If not,
-   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-   Boston, MA 02111-1307, USA.  */
-
-/*
- * isinfl(x) returns 1 if x is inf, -1 for x == -inf, else 0;
- */
-
-#include <sysdep.h>
-#undef ret
-
-ENTRY (__isinfl)
-{
-.mfi
-	fclass.m p6, p7 = farg0, @inf|@pos
-	;;
-}
-{
-.mfb
-(p6)	mov ret0 = 1
-(p7)	fclass.m p7, p8 = farg0, @inf|@neg
-(p6)	br.ret.sptk.many rp
-	;;
-}
-(p7)	mov ret0 = -1
-(p8)	mov ret0 = 0
-	br.ret.sptk.many rp
-}	
-END (__isinfl)
-
-weak_alias (__isinfl, isinfl)
+/* __isinfl is in s_isinf.S. */
Index: sysdeps/ia64/fpu/s_isnanl.S
===================================================================
RCS file: /work/cvs/gnu/glibc/sysdeps/ia64/fpu/s_isnanl.S,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 s_isnanl.S
--- sysdeps/ia64/fpu/s_isnanl.S	2000/11/07 01:29:42	1.1.1.1
+++ sysdeps/ia64/fpu/s_isnanl.S	2000/12/09 00:34:20
@@ -1,42 +1 @@
-/* Test for NaN
-   Copyright (C) 2000 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Jes Sorensen <jes@linuxcare.com>, October 2000.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Library General Public License as
-   published by the Free Software Foundation; either version 2 of the
-   License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Library General Public License for more details.
-
-   You should have received a copy of the GNU Library General Public
-   License along with the GNU C Library; see the file COPYING.LIB.  If not,
-   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-   Boston, MA 02111-1307, USA.  */
-
-/*
- * isnanl(x) returns 1 is x is nan, else 0;
- */
-
-#include <sysdep.h>
-#undef ret
-
-ENTRY (__isnanl)
-{
-.mfi
-	fclass.m p6, p7 = farg0, @nat | @qnan | @snan
-	;;
-}
-{
-.mib
-(p6)	mov ret0 = 1
-(p7)	mov ret0 = 0
-	br.ret.sptk.many rp
-}	
-END (__isnanl)
-
-weak_alias (__isnanl, isnanl)
+/* __isnanl is in s_isnan.S. */
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ sysdeps/ia64/fpu/s_isinf.S	Fri Dec  8 16:46:30 2000
@@ -0,0 +1,54 @@
+/* Test for inf/-inf
+   Copyright (C) 2000 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Jes Sorensen <jes@linuxcare.com>, October 2000.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+/*
+ * isinf(x) returns 1 if x is inf, -1 for x == -inf, else 0;
+ */
+
+#include <sysdep.h>
+#undef ret
+
+ENTRY (__isinf)
+{
+.mfi
+	fclass.m p6, p7 = farg0, @inf|@pos
+	;;
+}
+{
+.mfb
+(p6)	mov ret0 = 1
+(p7)	fclass.m p7, p8 = farg0, @inf|@neg
+(p6)	br.ret.sptk.many rp
+	;;
+}
+{
+	.pred.rel.mutex p7,p8
+(p7)	mov ret0 = -1
+(p8)	mov ret0 = 0
+	br.ret.sptk.many rp
+}	
+END (__isinf)
+
+strong_alias (__isinf, __isinff)
+strong_alias (__isinf, __isinfl)
+
+weak_alias (__isinf, isinf)
+weak_alias (__isinff, isinff)
+weak_alias (__isinfl, isinfl)
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ sysdeps/ia64/fpu/s_isnan.S	Fri Dec  8 16:33:02 2000
@@ -0,0 +1,47 @@
+/* Test for NaN
+   Copyright (C) 2000 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Jes Sorensen <jes@linuxcare.com>, October 2000.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+/*
+ * isnan(x) returns 1 is x is nan, else 0;
+ */
+
+#include <sysdep.h>
+#undef ret
+
+ENTRY (__isnan)
+{
+.mfi
+	fclass.m p6, p7 = farg0, @nat | @qnan | @snan
+	;;
+}
+{
+.mib
+(p6)	mov ret0 = 1
+(p7)	mov ret0 = 0
+	br.ret.sptk.many rp
+}	
+END (__isnan)
+
+strong_alias (__isnan, __isnanf)
+strong_alias (__isnan, __isnanl)
+
+weak_alias (__isnan, isnan)
+weak_alias (__isnanf, isnanf)
+weak_alias (__isnanl, isnanl)
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ sysdeps/ia64/fpu/s_fpclassify.S	Fri Dec  8 16:36:45 2000
@@ -0,0 +1,59 @@
+/* Return classification value corresponding to argument.
+   Copyright (C) 2000 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#include <sysdep.h>
+#undef ret
+
+ENTRY (__fpclassify)
+{
+.mfi
+	fclass.m p6, p7 = farg0, @nat | @qnan | @snan
+	;;
+}
+{
+.mfb
+(p6)	mov ret0 = 0
+(p7)	fclass.m p7, p8 = farg0, @inf
+(p6)	br.ret.sptk.many rp
+	;;
+}	
+{
+.mfb
+(p7)	mov ret0 = 1
+(p8)	fclass.m p8, p6 = farg0, @zero
+(p7)	br.ret.sptk.many rp
+	;;
+}
+{
+.mfb
+(p8)	mov ret0 = 2
+(p6)	fclass.m p6, p7 = farg0, @unorm
+(p8)	br.ret.sptk.many rp
+	;;
+}
+{
+	.pred.rel.mutex p6, p7
+(p6)	mov ret0 = 3
+(p7)	mov ret0 = 4
+	br.ret.sptk.many rp
+}
+END (__fpclassify)
+
+strong_alias (__fpclassify, __fpclassifyf)
+strong_alias (__fpclassify, __fpclassifyl)
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ sysdeps/ia64/fpu/s_fpclassifyf.S	Fri Dec  8 15:00:22 2000
@@ -0,0 +1 @@
+/* __fpclassifyf is in s_fpclassify.S. */
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ sysdeps/ia64/fpu/s_fpclassifyl.S	Fri Dec  8 15:00:11 2000
@@ -0,0 +1 @@
+/* __fpclassifyl is in s_fpclassify.S. */
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ sysdeps/ia64/fpu/s_isinff.S	Fri Dec  8 16:33:58 2000
@@ -0,0 +1 @@
+/* __isinff is in s_isinf.S. */
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ sysdeps/ia64/fpu/s_isnanf.S	Fri Dec  8 16:34:30 2000
@@ -0,0 +1 @@
+/* __isnanf is in s_isnan.S. */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]