This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Possible bug in sysdeps/unix/sysv/linux/powerpc/mmap64.c


"H . J . Lu" <hjl@lucon.org> writes:

> Here is a proposed patch.

Unless somebody who's responsible for the kernel part that the page
size can be changed there is no need for a patch like this.  If it is
agreed on that it is necessary this

> +  if (!page_size)
>      {
> +      page_size = __getpagesize ();
> +      page_shift = __ffs (page_size) - 1;
> +    }
> +
> +  if (offset & (page_size - 1))

should be rewritten to store the page size minus one in a variable
instead of computing it every time again.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]