This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Missing type in elf/start.S


On Mon, Jun 04, 2001 at 09:52:07PM +0200, Andreas Jaeger wrote:
> > is missing from most of elf/start.S. On some platforms, the dissambler
> > won't dissamble if a symbol is not a function. Should I send a patch
> > to fix it?
> 
> Please do so,
> 

Here it is.


H.J.
----
2001-06-04  H.J. Lu  <hjl@gnu.org>

	* sysdeps/alpha/elf/start.S: Add .type for the entry point.
	* sysdeps/arm/elf/start.S: Likewise.
	* sysdeps/hppa/elf/start.S: Likewise.
	* sysdeps/i386/elf/start.S: Likewise.
	* sysdeps/m68k/elf/start.S: Likewise.
	* sysdeps/mips/elf/start.S: Likewise.
	* sysdeps/ia64/elf/start.S: Likewise.
	* sysdeps/sh/elf/start.S: Likewise.
	* sysdeps/s390/s390-32/elf/start.S: Likewise.
	* sysdeps/s390/s390-64/elf/start.S: Likewise.
	* sysdeps/cris/elf/start.S: Likewise.

Index: sysdeps/alpha/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/alpha/elf/start.S,v
retrieving revision 1.9
diff -u -p -r1.9 start.S
--- sysdeps/alpha/elf/start.S	2000/12/06 04:05:25	1.9
+++ sysdeps/alpha/elf/start.S	2001/06/04 20:15:37
@@ -24,6 +24,7 @@
 	.align 3
 	.globl _start
 	.ent _start, 0
+	.type _start,@function
 _start:
 	.frame fp, 0, zero
 	mov	zero, fp
Index: sysdeps/arm/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/arm/elf/start.S,v
retrieving revision 1.2
diff -u -p -r1.2 start.S
--- sysdeps/arm/elf/start.S	1998/04/01 09:09:05	1.2
+++ sysdeps/arm/elf/start.S	2001/06/04 20:15:37
@@ -43,6 +43,7 @@
 
 	.text
 	.globl _start
+	.type _start,@function
 _start:
 	/* Clear the frame pointer since this is the outermost frame.  */
 	mov fp, #0
Index: sysdeps/hppa/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/hppa/elf/start.S,v
retrieving revision 1.1
diff -u -p -r1.1 start.S
--- sysdeps/hppa/elf/start.S	2000/10/15 03:33:33	1.1
+++ sysdeps/hppa/elf/start.S	2001/06/04 20:15:37
@@ -14,7 +14,7 @@
 	
 	.globl _start
 	.export _start, ENTRY
-
+	.type _start,@function
 _start:
 
 	.proc
Index: sysdeps/i386/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/i386/elf/start.S,v
retrieving revision 1.16
diff -u -p -r1.16 start.S
--- sysdeps/i386/elf/start.S	2001/02/22 19:57:34	1.16
+++ sysdeps/i386/elf/start.S	2001/06/04 20:15:37
@@ -40,6 +40,7 @@
 
 	.text
 	.globl _start
+	.type _start,@function
 _start:
 	/* Clear the frame pointer.  The ABI suggests this be done, to mark
 	   the outermost frame obviously.  */
Index: sysdeps/m68k/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/m68k/elf/start.S,v
retrieving revision 1.4
diff -u -p -r1.4 start.S
--- sysdeps/m68k/elf/start.S	1998/06/10 01:35:06	1.4
+++ sysdeps/m68k/elf/start.S	2001/06/04 20:15:38
@@ -38,6 +38,7 @@
 
 	.text
 	.globl _start
+	.type _start,@function
 _start:
 	/* Clear the frame pointer.  The ABI suggests this be done, to mark
 	   the outermost frame obviously.  */
Index: sysdeps/mips/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/mips/elf/start.S,v
retrieving revision 1.9
diff -u -p -r1.9 start.S
--- sysdeps/mips/elf/start.S	2001/04/11 11:56:35	1.9
+++ sysdeps/mips/elf/start.S	2001/06/04 20:15:38
@@ -67,6 +67,7 @@
 
 	.text
 	.globl ENTRY_POINT
+	.type ENTRY_POINT,@function
 ENTRY_POINT:
 #ifdef __PIC__
 	SET_GP
Index: sysdeps/ia64/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/ia64/elf/start.S,v
retrieving revision 1.7
diff -u -p -r1.7 start.S
--- sysdeps/ia64/elf/start.S	2001/05/27 06:37:25	1.7
+++ sysdeps/ia64/elf/start.S	2001/06/04 20:15:38
@@ -37,6 +37,7 @@
 	.global _start
 
 	.proc _start
+	type _start,@function
 _start:
 	.prologue
 	{ .mlx
Index: sysdeps/sh/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/sh/elf/start.S,v
retrieving revision 1.1
diff -u -p -r1.1 start.S
--- sysdeps/sh/elf/start.S	2000/06/12 20:24:41	1.1
+++ sysdeps/sh/elf/start.S	2001/06/04 20:15:38
@@ -43,6 +43,7 @@
 
 	.text
 	.globl _start
+	type _start,@function
 _start:
 	/* Clear the frame pointer since this is the outermost frame.  */
 	mov #0, r14
Index: sysdeps/s390/s390-32/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/s390/s390-32/elf/start.S,v
retrieving revision 1.1
diff -u -p -r1.1 start.S
--- sysdeps/s390/s390-32/elf/start.S	2001/03/16 09:09:18	1.1
+++ sysdeps/s390/s390-32/elf/start.S	2001/06/04 20:15:38
@@ -39,6 +39,7 @@
 
 	.text
 	.globl _start
+	type _start,@function
 _start:
 	/* Setup pointer to literal pool of _start */
 	basr    %r13,0
Index: sysdeps/s390/s390-64/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/s390/s390-64/elf/start.S,v
retrieving revision 1.1
diff -u -p -r1.1 start.S
--- sysdeps/s390/s390-64/elf/start.S	2001/03/16 09:18:07	1.1
+++ sysdeps/s390/s390-64/elf/start.S	2001/06/04 20:15:38
@@ -39,6 +39,7 @@
 
 	.text
 	.globl _start
+	type _start,@function
 _start:
 	/* Load argc and argv from stack.  */
 	la	%r4,8(%r15)		# get argv
Index: sysdeps/cris/elf/start.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/cris/elf/start.S,v
retrieving revision 1.1
diff -u -p -r1.1 start.S
--- sysdeps/cris/elf/start.S	2001/04/10 00:22:36	1.1
+++ sysdeps/cris/elf/start.S	2001/06/04 20:15:39
@@ -42,6 +42,7 @@
 
 	.text
 	.globl	_start
+	type _start,@function
 _start:
 	/* Clear the frame pointer, to mark the outermost frame.  */
 	moveq	0,r8


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]