Re: PATCH: glibc port to solaris2

[Andreas Jaeger <aj at suse dot de>]

esp5 <esp5@rama.comp.pge.com> writes:

> ok, here's a patch to make glibc-2.2.4 compile on solaris2.6... well,  
> it compiles 99% of the way through, and gets to the following segfault

Does it really make sense to support Solaris 2.6 since it's an old
version?

[...]
> Anyways, here's the patch. Its not the cleanest, let me know what I need to do
> to make it include-able inside of glibc...

You need to conform to the GNU coding standards and sign the copyright
papers (ask me offline for details if you're interested).

You also should send patches for generic files separatly - and explain
each and every change.

> Apply with patch -p1 -d glib_dir < solaris2_6_patch..
>
> Cheers,
>
> Ed
> diff -rcP glibc-2.2.4.old/include/signal.h glibc-2.2.4/include/signal.h
> *** glibc-2.2.4.old/include/signal.h	Tue Oct  2 16:39:58 2001
> --- glibc-2.2.4/include/signal.h	Mon Oct  8 13:58:33 2001
> ***************
> *** 1,8 ****
> --- 1,10 ----
>   #ifndef _SIGNAL_H
>   #if defined __need_sig_atomic_t || defined __need_sigset_t
>   # include <signal/signal.h>
> + #include <bits/sigset.h>
>   #else
>   # include <signal/signal.h>
> + #include <bits/sigset.h>

Indent like the rest - and tell us why this is needed.  It looks
wrong.

[...]
> diff -rcP glibc-2.2.4.old/sysdeps/unix/sysv/sysv4/solaris2/Implies glibc-2.2.4/sysdeps/unix/sysv/sysv4/solaris2/Implies
> *** glibc-2.2.4.old/sysdeps/unix/sysv/sysv4/solaris2/Implies	Wed Dec 31 17:00:00 1969
> --- glibc-2.2.4/sysdeps/unix/sysv/sysv4/solaris2/Implies	Fri Oct  5 12:38:19 2001
> ***************
> *** 0 ****
> --- 1,13 ----
> + # The gnu subdirectory exists for things common to both Linux-based and
> + # Hurd-based GNU systems.
> + 
> + # Linux shares most of the syscalls which are also common to BSD and SVR4.
> + unix/common
> + 
> + # Linux as of version 1.3.29 has all functions of the mmap family
> + # which are described in POSIX.4.  Missing is only madvise() so
> + # we define a stub here.
> + unix/mman
> + 
> + # Linux has network support in the kernel.
> + unix/inet

Linux?  Please fix those comments.
> diff -rcP glibc-2.2.4.old/sysdeps/unix/sysv/sysv4/solaris2/bits/fcntl.h glibc-2.2.4/sysdeps/unix/sysv/sysv4/solaris2/bits/fcntl.h
> *** glibc-2.2.4.old/sysdeps/unix/sysv/sysv4/solaris2/bits/fcntl.h	Wed Oct  3 10:57:48 2001
> --- glibc-2.2.4/sysdeps/unix/sysv/sysv4/solaris2/bits/fcntl.h	Thu Oct  4 19:19:20 2001
> ***************
> *** 0 ****
> --- 1,123 ----
> + /* O_*, F_*, FD_* bit values for general Unix system.

Please adjust such comments.

I advise to send first only the fixes for the generic files with a
proper explanation why they're needed before looking at the Solaris2
specific files.

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj