This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: "make install" is incomplete
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Bruno Haible <bruno at clisp dot org>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Thu, 16 May 2002 13:52:39 +0200
- Subject: Re: "make install" is incomplete
- References: <15587.38472.754476.512240@honolulu.ilog.fr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, May 16, 2002 at 01:21:44PM +0200, Bruno Haible wrote:
>
> Hi,
>
> After "make install", iconv will not handle the encodings that were added
> since the previously installed glibc version (assuming that was 2.2.4 or
> newer). Instead it will complain about an unsupported conversion. The
> reason is that the gconv-modules file has been replaced by the new one,
> but gconv-modules.cache is still the old one - and when iconv finds the
> cache file, it doesn't bother looking at the gconv-modules file (not even
> to check its modification time). The fix is obviously to run iconvconfig
> during "make install".
As iconvconfig is dynamically linked, you need to use
$(built-program-cmd) to run it IMHO.
Also, iconvconfig should first accept --prefix option and the Makefile
hunk needs to pass that to it (like e.g. ldconfig or localedef).
Messing up /usr/lib/gconv/gconv-modules.cache when installing glibc
with make install_root=/var/tmp/glibc install
is surely a very bad thing.
> 2002-05-16 Bruno Haible <bruno@clisp.org>
>
> * Makefile (install): Depend on install-run-iconvconfig.
> (install-run-iconvconfig): New rule.
>
> --- glibc-20020425/Makefile.bak Mon Apr 22 13:44:46 2002
> +++ glibc-20020425/Makefile Thu May 16 01:54:46 2002
> @@ -124,6 +124,15 @@
> endif
> endif
>
> +# Update the $(prefix)/lib/gconv/gconv-modules.cache file. This is necessary
> +# if this libc has more gconv modules than the previously installed one.
> +ifeq (no,$(cross-compiling))
> +install: install-run-iconvconfig
> +.PHONY: install-run-iconvconfig
> +install-run-iconvconfig: subdir_install
> + LC_ALL=C LANGUAGE=C $(common-objpfx)iconv/iconvconfig
> +endif
> +
> # Build subdirectory lib objects.
> lib-noranlib: subdir_lib
>
Jakub