This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] PowerPC64 port part 4 of 7
Ulrich Drepper wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Steve Munroe wrote:
>
> > Have you looked at the whole set? It is all separated out. That is why
> > there are 7 parts!
>
> Oh yeah?
>
> * sysdeps/powerpc/elf/libc-start.c : Scan Aux Vector for
> AT_DCACHEBSIZE and copy value to __cache_line_size.
> * sysdeps/unix/sysv/linux/powerpc/dl-sysdep.c : Scan Aux Vector for
> AT_DCACHEBSIZE and copy value to __cache_line_size.
> * sysdeps/powerpc/ppc32/memset.S : Define __cache_line_size and use
> its value to select the correct stride for dcbz.
> * sysdeps/powerpc/ppc64/memset.S : Define __cache_line_size and use
> its value to select the correct stride for dcbz.
>
> And this is only from part 4. I haven't even looked further.
>
> > Are there specific non-powerpc parts you find problematic?
>
> Any change to generic code is suspicous by default. You have to justify
> each and every one of them.
The memset patch should have been in a month ago as it was posted to the
libc-alpha list early in July! That fixes a problem which has been a constant
thorn in the PPC backside for a LOOOOOOONNNNNNNGGGGGGGG time.
Any particular reason why that wasn't accepted?
Regards,
Tom
--
Tom Gall - [Embedded] [ppc|ppc64] Code Monkey
Peace, Love and Linux Technology Center "Where's the ka-boom?
(h) tgall@rochcivictheatre.org supposed to be an earth
(w) tom_gall@vnet.ibm.com shattering ka-boom!"
(w) 507-253-4558 -- Marvin Martian
http://www.ibm.com/linux/ltc