This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC64 port part 1 of 7


Roland McGrath wrote

> You should use the machine names emitted by config.sub, not ones of your
> own making.  The canonical names are powerpc64 and powerpc.  For files in
> sysdeps/powerpc that are overridden by new powerpc64 files, I don't see a
> real reason to move the existing files to a new subdir, though it doesn't
> hurt and it matches what was done for sparc.  If there is a need for a
> 32-bit-only directory, then it should be called powerpc32 (cf sparc32).

PowerPC requires a directory structure similar to sparc (common code with
32- and 64-bit specific subdirectories). There is C code that is PowerPC
specific but common to 32-/64-bit. Also a key goal is that include files
(that end up in /usr/include) be common between 32-/64-bit for PowerPC.
Some of these include files require #ifdef __powerpc64__ conditions to
maintain this commonality.

Then there is the powerpc asm (*.S) code which uses different instructions
to load pointers (lwz vs. ld) and different stack layouts for 32- and
64-bit code. These require separate implementations, each in their own
subtree.

As for the exact spelling, I discussed this with Geoff long ago and thought
I had agreement to the shorter ppc32/ppc64 for the subdirectores. PPC is
widely recognized as the abbreviation for PowerPC (TM). Also there was
precedent in the source tree of the Linux kernel which uses ppc and ppc64.

So I would like to leave this as is. But in interest for moving forward I
am willing to compromise and change it if Geoff agrees.

Geoff please respond asap, as I would like to resubmit patches 1 and 2.
This is the minimum required to establish the new tree structure and make
the configuration functional for powerpc and powerpc64. While patch 1 is
still a very big, it is only moving files with the directory structure.
Doing this move incrementally would be too disruptive to the existing
PowerPC community.

This will make it practical to start incremental submission of the
powerpc64 changes.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]