This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: HAVE_HIDDEN doesnt always mean DONT_USE_BOOTSTRAP_MAP


"Steve Munroe" <sjmunroe@us.ibm.com> writes:

> Ulrich Drepper wrote:
>
>> I think you've been told numerous times that using #ifs to test for
>> architectures is wrong.  Not only this, it's the single biggest sin.
>
> Ok I will use __WORDSIZE and HAVE_ASM_GLOBAL_DOT_NAME where appropriate.
> However I suspect that use of #ifdefs for architectures is not always a
> sin. Two examples come to mind:
>
>       ./stdlib/longlong.h

That one comes from libgmp and is copied.

>       ./sysdeps/unix/sysv/linux/kernel-features.h

And that's the only exception.

>
> Then there are the various forms of wordsize.h on architectures that
> support both 32- and 64-bit. How else will __WORDSIZE get set correctly?
>
> Are these the only exceptions?

Yes, they are.

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]