This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
FreeBSD port (41): a few comments
- From: Bruno Haible <bruno at clisp dot org>
- To: Roland McGrath <roland at frob dot com>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Thu, 5 Sep 2002 14:12:39 +0200 (CEST)
- Subject: FreeBSD port (41): a few comments
Please add these comments. It is a shame to install <bits/ustat.h> without
documenting its fields. It is a shame to install <sys/sendfile.h> with an
unusable documentation of sendfile().
diff -r -c3 glibc-20020828.bak/sysdeps/generic/bits/ustat.h glibc-20020828/sysdeps/generic/bits/ustat.h
*** glibc-20020828.bak/sysdeps/generic/bits/ustat.h Tue Jul 9 19:55:37 2002
--- glibc-20020828/sysdeps/generic/bits/ustat.h Wed Sep 4 05:35:06 2002
***************
*** 24,31 ****
struct ustat
{
! __daddr_t f_tfree;
! __ino_t f_tinode;
char f_fname[6];
char f_fpack[6];
};
--- 24,31 ----
struct ustat
{
! __daddr_t f_tfree; /* Number of free blocks. */
! __ino_t f_tinode; /* Number of free inodes. */
char f_fname[6];
char f_fpack[6];
};
diff -r -c3 glibc-20020828.bak/io/sys/sendfile.h glibc-20020828/io/sys/sendfile.h
*** glibc-20020828.bak/io/sys/sendfile.h Wed Jun 5 10:56:16 2002
--- glibc-20020828/io/sys/sendfile.h Fri Aug 30 11:04:30 2002
***************
*** 25,32 ****
__BEGIN_DECLS
! /* Send COUNT bytes from file associated with IN_FD starting at OFFSET to
! descriptor OUT_FD. */
#ifndef __USE_FILE_OFFSET64
extern ssize_t sendfile (int __out_fd, int __in_fd, off_t *__offset,
size_t __count) __THROW;
--- 25,34 ----
__BEGIN_DECLS
! /* Send up to COUNT bytes from file associated with IN_FD starting at *OFFSET
! to descriptor OUT_FD. Set *OFFSET to the IN_FD's file position following
! the read bytes. If OFFSET is NULL, the normal file position is used
! instead. Return the number of written bytes, or -1 in case of error. */
#ifndef __USE_FILE_OFFSET64
extern ssize_t sendfile (int __out_fd, int __in_fd, off_t *__offset,
size_t __count) __THROW;
diff -r -c3 glibc-20020828.bak/sysdeps/posix/pread.c glibc-20020828/sysdeps/posix/pread.c
*** glibc-20020828.bak/sysdeps/posix/pread.c Tue Jul 10 23:01:08 2001
--- glibc-20020828/sysdeps/posix/pread.c Fri Aug 30 11:04:33 2002
***************
*** 1,6 ****
/* Read block from given position in file without changing file pointer.
POSIX version.
! Copyright (C) 1997, 1998, 1999 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
--- 1,6 ----
/* Read block from given position in file without changing file pointer.
POSIX version.
! Copyright (C) 1997, 1998, 1999, 2002 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
***************
*** 22,27 ****
--- 22,29 ----
#include <errno.h>
#include <unistd.h>
+ /* Note: This implementation of pread is not multithread-safe. */
+
ssize_t
__libc_pread (int fd, void *buf, size_t nbyte, off_t offset)
{
diff -r -c3 glibc-20020828.bak/sysdeps/posix/pread64.c glibc-20020828/sysdeps/posix/pread64.c
*** glibc-20020828.bak/sysdeps/posix/pread64.c Tue Jul 10 23:01:08 2001
--- glibc-20020828/sysdeps/posix/pread64.c Fri Aug 30 11:04:33 2002
***************
*** 1,6 ****
/* Read block from given position in file without changing file pointer.
POSIX version.
! Copyright (C) 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
--- 1,6 ----
/* Read block from given position in file without changing file pointer.
POSIX version.
! Copyright (C) 1997, 1998, 1999, 2000, 2002 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
***************
*** 22,27 ****
--- 22,29 ----
#include <errno.h>
#include <unistd.h>
+ /* Note: This implementation of pread64 is not multithread-safe. */
+
ssize_t
__libc_pread64 (int fd, void *buf, size_t nbyte, off64_t offset)
{
diff -r -c3 glibc-20020828.bak/sysdeps/posix/pwrite.c glibc-20020828/sysdeps/posix/pwrite.c
*** glibc-20020828.bak/sysdeps/posix/pwrite.c Tue Jul 10 23:01:08 2001
--- glibc-20020828/sysdeps/posix/pwrite.c Fri Aug 30 11:04:33 2002
***************
*** 1,6 ****
/* Write block to given position in file without changing file pointer.
POSIX version.
! Copyright (C) 1997, 1998, 1999 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
--- 1,6 ----
/* Write block to given position in file without changing file pointer.
POSIX version.
! Copyright (C) 1997, 1998, 1999, 2002 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
***************
*** 22,27 ****
--- 22,29 ----
#include <errno.h>
#include <unistd.h>
+ /* Note: This implementation of pwrite is not multithread-safe. */
+
ssize_t
__libc_pwrite (int fd, const void *buf, size_t nbyte, off_t offset)
{
diff -r -c3 glibc-20020828.bak/sysdeps/posix/pwrite64.c glibc-20020828/sysdeps/posix/pwrite64.c
*** glibc-20020828.bak/sysdeps/posix/pwrite64.c Mon Aug 5 13:24:44 2002
--- glibc-20020828/sysdeps/posix/pwrite64.c Fri Aug 30 11:33:38 2002
***************
*** 22,27 ****
--- 22,29 ----
#include <errno.h>
#include <unistd.h>
+ /* Note: This implementation of pwrite64 is not multithread-safe. */
+
ssize_t
__libc_pwrite64 (int fd, const void *buf, size_t nbyte, off64_t offset)
{