This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ppc64 specific sysdep.h changes


Roland McGrath writes:

> > Roland McGrath writes:
> >
> > > Why not just make a sysdeps/powerpc/powerpc64/sysdep.h?
> > >It can include <sysdeps/powerpc/sysdep.h> for the common parts.
> >
> > Wanted to share the register defines powerpc32 and this was the
simplest
> > way.
>
> In what way is it simpler than #include <sysdeps/powerpc/sysdep.h>?

Because <sysdeps/powerpc/sysdep.h> still has powerpc32 specific stuff
powerpc64 does not want.

So two choices:

Put everything in sysdeps/powerpc and user #if __WORDSIZE == 64 to
discriminate.

or

Split <sysdeps/powerpc/sysdep.h> into <sysdeps/powerpc/sysdep.h> (common
powerpc stuff) and <sysdeps/powerpc/powerpc32/sysdep.h>(powerpc32 specific
stuff)  then add <sysdeps/powerpc/powerpc64/sysdep.h> (powerpc64 specific
stuff).

It just seemed simpler in this case to use the #if.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]