This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] ppc32 dl-machine.c
- From: Geoff Keating <geoffk at geoffk dot org>
- To: sjmunroe at vnet dot ibm dot com
- Cc: libc-alpha at sources dot redhat dot com, anton at samba dot org, roland at frob dot com
- Date: Wed, 25 Sep 2002 09:47:09 -0700
- Subject: Re: [PATCH] ppc32 dl-machine.c
- References: <200209251529.g8PFTtv24055@brule.rchland.ibm.com>
The original proposed patch was something like:
--- glibc-2.2.5/sysdeps/powerpc/dl-machine.c~ Sun Sep 9 07:21:34
2001
+++ glibc-2.2.5/sysdeps/powerpc/dl-machine.c Fri May 10 12:58:04
2002
@@ -311,7 +311,8 @@
PPC_DCBST (plt + i);
PPC_DCBST (plt + size_modified - 1);
PPC_SYNC;
- PPC_ICBI (plt);
+ for (i = 0; i < size_modified; i += 4)
+ PPC_ICBI (plt + i);
PPC_ICBI (plt + size_modified - 1);
PPC_ISYNC;
}
your patch looks much less efficient. Can you explain the
differences?
Please remember, PPC_SYNC is a very expensive operation. It
requires a bus broadcast and therefore takes tens of cycles.
--
- Geoffrey Keating <geoffk@geoffk.org>